Fix ThreadSanitizer issues in App Engine runtime tests.

PiperOrigin-RevId: 888863426
Change-Id: Ib3f59c527b9e2a34ae6b78eff52139e3242f5260

Author: ludoch

runtime/runtime_impl_jetty121/src/test/java/com/google/apphosting/runtime/grpc/FakeApiProxyImplFactory.java

@@ -28,6 +28,7 @@
 import com.google.apphosting.runtime.timer.TimerFactory;
 import java.time.Duration;
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.List;
 import java.util.concurrent.Future;
 import java.util.concurrent.Semaphore;
@@ -68,7 +69,7 @@ public static ApiProxyImpl.EnvironmentImpl fakeEnvironment(
   public static ApiProxyImpl.EnvironmentImpl fakeEnvironment(
       ApiProxyImpl apiProxyImpl, String securityTicket, TraceWriter traceWriter) {
     Semaphore outstandingApiRpcSemaphore = new Semaphore(1);
-    List<Future<?>> asyncFutures = new ArrayList<>();
+    List<Future<?>> asyncFutures = Collections.synchronizedList(new ArrayList<>());
     RuntimePb.UPRequest request =
         RuntimePb.UPRequest.newBuilder().setSecurityTicket(securityTicket).buildPartial();
     return apiProxyImpl.createEnvironment(

runtime/runtime_impl_jetty121/src/test/java/com/google/apphosting/runtime/http/tsan_suppressions.txt

@@ -0,0 +1,5 @@
+# Suppress known ThreadSanitizer data race in Jetty's SelectableChannelEndPoint
+# This is caused by logging the endpoint string concurrently with updateKey().
+race:org.eclipse.jetty.io.SelectableChannelEndPoint
+race:org.eclipse.jetty.io.ChannelEndPoint
+race:org.eclipse.jetty.server.AbstractConnector

runtime/runtime_impl_jetty9/src/test/java/com/google/apphosting/runtime/grpc/FakeApiProxyImplFactory.java

@@ -28,6 +28,7 @@
 import com.google.apphosting.runtime.timer.TimerFactory;
 import java.time.Duration;
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.List;
 import java.util.concurrent.Future;
 import java.util.concurrent.Semaphore;
@@ -68,7 +69,7 @@ public static ApiProxyImpl.EnvironmentImpl fakeEnvironment(
   public static ApiProxyImpl.EnvironmentImpl fakeEnvironment(
       ApiProxyImpl apiProxyImpl, String securityTicket, TraceWriter traceWriter) {
     Semaphore outstandingApiRpcSemaphore = new Semaphore(1);
-    List<Future<?>> asyncFutures = new ArrayList<>();
+    List<Future<?>> asyncFutures = Collections.synchronizedList(new ArrayList<>());
     RuntimePb.UPRequest request =
         RuntimePb.UPRequest.newBuilder().setSecurityTicket(securityTicket).buildPartial();
     return apiProxyImpl.createEnvironment(

runtime/runtime_impl_jetty9/src/test/java/com/google/apphosting/runtime/http/tsan_suppressions.txt

@@ -0,0 +1,5 @@
+# Suppress known ThreadSanitizer data race in Jetty's SelectableChannelEndPoint
+# This is caused by logging the endpoint string concurrently with updateKey().
+race:org.eclipse.jetty.io.SelectableChannelEndPoint
+race:org.eclipse.jetty.io.ChannelEndPoint
+race:org.eclipse.jetty.server.AbstractConnector