Skip to content

fix(go): stop eval'ing GIT_CONFIG_VAL as shell #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
evilgensec wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(go): stop eval'ing GIT_CONFIG_VAL as shell #1098

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions go/prepare_workspace.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,13 @@
# limitations under the License.

prepare_workspace() {
# If $GIT_CONFIG_VAL is set, set global git config value
# If $GIT_CONFIG_VAL is set, set global git config value. Pipe through
# xargs so that shell-quoted values are tokenized into argv positions
# rather than re-evaluated by the shell; otherwise any $(...), `...`,
# ; or && embedded in GIT_CONFIG_VAL would execute as shell when this
# builder image runs inside a Cloud Build step.
if [[ "$GIT_CONFIG_VAL" ]]; then
eval "git config --global $GIT_CONFIG_VAL"
printf '%s' "$GIT_CONFIG_VAL" | xargs git config --global
fi

# We record the original working directory because some tools need to
Expand Down