Skip to content

Commit ee56632

Browse files
drewhlicopybara-github
authored andcommitted
Remove completed/obsolete TODOs.
PiperOrigin-RevId: 955982822
1 parent 6b20607 commit ee56632

2 files changed

Lines changed: 0 additions & 15 deletions

File tree

test_suites/guestagent/windows_password_test.go

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -251,15 +251,6 @@ func TestWindowsPasswordResetDifferentLocale(t *testing.T) {
251251
t.Skip("Skipping test as it tests a feature that is not currently generally available in the guest agent.")
252252
}
253253

254-
// TODO(b/478892615): Remove this skip once the fix is released.
255-
image, err := utils.GetMetadata(utils.Context(t), "instance", "image")
256-
if err != nil {
257-
t.Fatalf("could not determine image: %v", err)
258-
}
259-
if !strings.Contains(image, "guest-agent") {
260-
t.Skip("Skipping test as it tests a feature that is not currently generally available in the guest agent.")
261-
}
262-
263254
// This feature is only implemented in the core plugin.
264255
if utils.IsCoreDisabled() {
265256
t.Skip("Skipping test as core plugin is disabled")

test_suites/pluginmanager/pluginmanager_test.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -689,9 +689,6 @@ func TestLocalPlugin(t *testing.T) {
689689

690690
// With local plugins enabled, check to see that all plugins are running.
691691
for _, plugin := range plugins {
692-
if strings.Contains(plugin, "GuestTelemetryExtension") { // TODO(b/505402355): Re-enable when local plugins are enabled.
693-
continue
694-
}
695692
if runtime.GOOS == "windows" {
696693
// Remove the .exe extension from the plugin name for the verifications.
697694
plugin = strings.TrimSuffix(plugin, ".exe")
@@ -700,9 +697,6 @@ func TestLocalPlugin(t *testing.T) {
700697
utils.VerifyProcessExistsLinux(t, true, filepath.Join(pluginsDir, plugin))
701698
}
702699
}
703-
704-
// TODO(b/489540405): Add test to disable local plugins and verify that all
705-
// non-core plugins are not running.
706700
}
707701

708702
func startTestServer(t *testing.T) (*grpc.Server, string) {

0 commit comments

Comments
 (0)