Skip to content

Remove completed/obsolete TODOs. #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jul 29, 2026
+0 −15
Merged

Remove completed/obsolete TODOs. #577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions test_suites/guestagent/windows_password_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,15 +251,6 @@ func TestWindowsPasswordResetDifferentLocale(t *testing.T) {
t.Skip("Skipping test as it tests a feature that is not currently generally available in the guest agent.")
}

// TODO(b/478892615): Remove this skip once the fix is released.
image, err := utils.GetMetadata(utils.Context(t), "instance", "image")
if err != nil {
t.Fatalf("could not determine image: %v", err)
}
if !strings.Contains(image, "guest-agent") {
t.Skip("Skipping test as it tests a feature that is not currently generally available in the guest agent.")
}

// This feature is only implemented in the core plugin.
if utils.IsCoreDisabled() {
t.Skip("Skipping test as core plugin is disabled")
Expand Down
6 changes: 0 additions & 6 deletions test_suites/pluginmanager/pluginmanager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,9 +689,6 @@ func TestLocalPlugin(t *testing.T) {

// With local plugins enabled, check to see that all plugins are running.
for _, plugin := range plugins {
if strings.Contains(plugin, "GuestTelemetryExtension") { // TODO(b/505402355): Re-enable when local plugins are enabled.
continue
}
if runtime.GOOS == "windows" {
// Remove the .exe extension from the plugin name for the verifications.
plugin = strings.TrimSuffix(plugin, ".exe")
Expand All @@ -700,9 +697,6 @@ func TestLocalPlugin(t *testing.T) {
utils.VerifyProcessExistsLinux(t, true, filepath.Join(pluginsDir, plugin))
}
}

// TODO(b/489540405): Add test to disable local plugins and verify that all
// non-core plugins are not running.
}

func startTestServer(t *testing.T) (*grpc.Server, string) {
Expand Down