Conversation
enocom
left a comment
There was a problem hiding this comment.
You can solve this problem without a breaking change like this: GoogleCloudPlatform/alloydb-go-connector#767
+1 to this approach. We can remove the dependency on pgxv4 without breaking our public API. |
35d8c90 to
3956c1b
Compare
Good call! |
Yeah this is good suggestion. Thank you @hessjcg . Btw, since we are not breaking our API with this approach. We might have to reconsider Major vs Minor upgrade for our release. |
enocom
left a comment
There was a problem hiding this comment.
This should be a fix commit in my opinion so you can alert users to the change.
hessjcg
left a comment
There was a problem hiding this comment.
With the caveat that the go version change goes in a separate PR.
Deprecate pgv4, due to the fact that https://github.com/jackc/pgproto3 is End of Life and no longer supported.