Skip to content

Commit 858a785

Browse files
committed
chore: try removing R2dbc changes
1 parent 08c342c commit 858a785

5 files changed

Lines changed: 5 additions & 10 deletions

File tree

r2dbc/mariadb/src/test/java/com/google/cloud/sql/core/R2dbcMariadbIntegrationTests.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ public class R2dbcMariadbIntegrationTests {
4545
private static final String DB_NAME = System.getenv("MYSQL_DB");
4646
private static final String DB_USER = System.getenv("MYSQL_USER");
4747
private static final String DB_PASSWORD = System.getenv("MYSQL_PASS");
48-
private static final String IP_TYPE = System.getenv("IP_TYPE") == null ? "PUBLIC" : System.getenv("IP_TYPE");
4948

5049
@Rule public Timeout globalTimeout = new Timeout(80, TimeUnit.SECONDS);
5150

@@ -65,7 +64,7 @@ public void setUpPool() {
6564
// Set up URL parameters
6665
String r2dbcURL =
6766
String.format(
68-
"r2dbc:gcp:mariadb://%s:%s@%s/%s?cloudSqlIpType=%s", DB_USER, DB_PASSWORD, CONNECTION_NAME, DB_NAME, IP_TYPE);
67+
"r2dbc:gcp:mariadb://%s:%s@%s/%s", DB_USER, DB_PASSWORD, CONNECTION_NAME, DB_NAME);
6968

7069
// Initialize connection pool
7170
ConnectionFactory connectionFactory = ConnectionFactories.get(r2dbcURL);

r2dbc/mysql/src/test/java/com/google/cloud/sql/core/R2dbcMysqlIntegrationTests.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ public class R2dbcMysqlIntegrationTests {
4545
private static final String DB_NAME = System.getenv("MYSQL_DB");
4646
private static final String DB_USER = System.getenv("MYSQL_USER");
4747
private static final String DB_PASSWORD = System.getenv("MYSQL_PASS");
48-
private static final String IP_TYPE = System.getenv("IP_TYPE") == null ? "PUBLIC" : System.getenv("IP_TYPE");
4948

5049
@Rule public Timeout globalTimeout = new Timeout(80, TimeUnit.SECONDS);
5150

@@ -65,7 +64,7 @@ public void setUpPool() {
6564
// Set up URL parameters
6665
String r2dbcURL =
6766
String.format(
68-
"r2dbc:gcp:mysql://%s:%s@%s/%s?cloudSqlIpType=%s", DB_USER, DB_PASSWORD, CONNECTION_NAME, DB_NAME, IP_TYPE);
67+
"r2dbc:gcp:mysql://%s:%s@%s/%s", DB_USER, DB_PASSWORD, CONNECTION_NAME, DB_NAME);
6968

7069
// Initialize connection pool
7170
ConnectionFactory connectionFactory = ConnectionFactories.get(r2dbcURL);

r2dbc/postgres/src/test/java/com/google/cloud/sql/core/R2dbcPostgresIntegrationTests.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ public class R2dbcPostgresIntegrationTests {
4242
private static final String DB_NAME = System.getenv("POSTGRES_DB");
4343
private static final String DB_USER = System.getenv("POSTGRES_USER");
4444
private static final String DB_PASSWORD = System.getenv("POSTGRES_PASS");
45-
private static final String IP_TYPE = System.getenv("IP_TYPE") == null ? "PUBLIC" : System.getenv("IP_TYPE");
4645
private static final ImmutableList<String> requiredEnvVars =
4746
ImmutableList.of("POSTGRES_USER", "POSTGRES_PASS", "POSTGRES_DB", "POSTGRES_CONNECTION_NAME");
4847
@Rule public Timeout globalTimeout = new Timeout(80, TimeUnit.SECONDS);
@@ -63,7 +62,7 @@ public void setUpPool() {
6362
// Set up URL parameters
6463
String r2dbcURL =
6564
String.format(
66-
"r2dbc:gcp:postgres://%s:%s@%s/%s?cloudSqlIpType=%s", DB_USER, DB_PASSWORD, CONNECTION_NAME, DB_NAME, IP_TYPE);
65+
"r2dbc:gcp:postgres://%s:%s@%s/%s", DB_USER, DB_PASSWORD, CONNECTION_NAME, DB_NAME);
6766

6867
// Initialize connection pool
6968
ConnectionFactory connectionFactory = ConnectionFactories.get(r2dbcURL);

r2dbc/postgres/src/test/java/com/google/cloud/sql/core/R2dbcPostgresPoolRemoteValidationIntegrationTests.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ public class R2dbcPostgresPoolRemoteValidationIntegrationTests {
4343
private static final String DB_NAME = System.getenv("POSTGRES_DB");
4444
private static final String DB_USER = System.getenv("POSTGRES_USER");
4545
private static final String DB_PASSWORD = System.getenv("POSTGRES_PASS");
46-
private static final String IP_TYPE = System.getenv("IP_TYPE") == null ? "PUBLIC" : System.getenv("IP_TYPE");
4746
private static final ImmutableList<String> requiredEnvVars =
4847
ImmutableList.of("POSTGRES_USER", "POSTGRES_PASS", "POSTGRES_DB", "POSTGRES_CONNECTION_NAME");
4948
@Rule public Timeout globalTimeout = new Timeout(80, TimeUnit.SECONDS);
@@ -64,7 +63,7 @@ public void setUpPool() {
6463
// Set up URL parameters
6564
String r2dbcURL =
6665
String.format(
67-
"r2dbc:gcp:postgres://%s:%s@%s/%s?cloudSqlIpType=%s", DB_USER, DB_PASSWORD, CONNECTION_NAME, DB_NAME, IP_TYPE);
66+
"r2dbc:gcp:postgres://%s:%s@%s/%s", DB_USER, DB_PASSWORD, CONNECTION_NAME, DB_NAME);
6867

6968
// Initialize connection pool with REMOTE validation
7069
ConnectionFactory connectionFactory = ConnectionFactories.get(r2dbcURL);

r2dbc/sqlserver/src/test/java/com/google/cloud/sql/core/R2dbcSqlserverIntegrationTests.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ public class R2dbcSqlserverIntegrationTests {
4545
private static final String DB_NAME = System.getenv("SQLSERVER_DB");
4646
private static final String DB_USER = System.getenv("SQLSERVER_USER");
4747
private static final String DB_PASSWORD = System.getenv("SQLSERVER_PASS");
48-
private static final String IP_TYPE = System.getenv("IP_TYPE") == null ? "PUBLIC" : System.getenv("IP_TYPE");
4948

5049
@Rule public Timeout globalTimeout = new Timeout(80, TimeUnit.SECONDS);
5150

@@ -65,7 +64,7 @@ public void setUpPool() {
6564
// Set up URL parameters
6665
String r2dbcURL =
6766
String.format(
68-
"r2dbc:gcp:mssql://%s:%s@%s/%s?cloudSqlIpType=%s", DB_USER, DB_PASSWORD, CONNECTION_NAME, DB_NAME, IP_TYPE);
67+
"r2dbc:gcp:mssql://%s:%s@%s/%s", DB_USER, DB_PASSWORD, CONNECTION_NAME, DB_NAME);
6968

7069
// Initialize connection pool
7170
ConnectionFactory connectionFactory = ConnectionFactories.get(r2dbcURL);

0 commit comments

Comments
 (0)