Skip to content

test: Fix flaky MonitoreCacheTest case that needs to wait for a background task #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hessjcg merged 1 commit into from
Mar 27, 2025
Merged

test: Fix flaky MonitoreCacheTest case that needs to wait for a background task #2133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion core/src/test/java/com/google/cloud/sql/core/MonitoredCacheTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,13 @@ public void testMonitoredCachePurgesClosedSockets() throws InterruptedException
cache.addSocket(socket);
Assert.assertEquals("1 socket in cache", 1, cache.getOpenSocketCount());
socket.close();
Thread.sleep(20);

// Wait for the MonitoredCache task to clean up the socket, up to 500ms.
for (int i = 0; cache.getOpenSocketCount() > 0 && i < 10; i++) {
Thread.sleep(50);
Copy link
Copy Markdown
Collaborator

@jackwotherspoon jackwotherspoon Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be 500? Comment says 500 milliseconds...

Copy link
Copy Markdown
Collaborator Author

@hessjcg hessjcg Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This waits 50ms up to 10 times, for a possible max of 500ms waiting.

}

// Ensure that the socket was removed from the cache.
Assert.assertEquals("0 socket in cache", 0, cache.getOpenSocketCount());
}

Expand Down
Loading