feat: Configure the connector using a DNS name.#422
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hessjcg
force-pushed
the
gh-421-dns-config
branch
8 times, most recently
from
3830941 to
c180e95
Compare
hessjcg
force-pushed
the
gh-421-dns-config
branch
2 times, most recently
from
e2d714c to
80eabe2
Compare
hessjcg
force-pushed
the
gh-421-dns-configuration
branch
from
8cbfbaa to
7f75770
Compare
hessjcg
force-pushed
the
gh-421-dns-config
branch
3 times, most recently
from
f24d64b to
ef914ea
Compare
hessjcg
force-pushed
the
gh-421-dns-configuration
branch
2 times, most recently
from
fa16e6a to
59dc310
Compare
hessjcg
force-pushed
the
gh-421-dns-config
branch
3 times, most recently
from
3f17979 to
4437c77
Compare
hessjcg
force-pushed
the
gh-421-dns-configuration
branch
from
59dc310 to
03cc7cc
Compare
hessjcg
force-pushed
the
gh-421-dns-config
branch
2 times, most recently
from
5c87d71 to
b867453
Compare
hessjcg
force-pushed
the
gh-421-dns-configuration
branch
from
03cc7cc to
7faa99b
Compare
hessjcg
force-pushed
the
gh-421-dns-configuration
branch
from
7faa99b to
303333c
Compare
hessjcg
force-pushed
the
gh-421-dns-config
branch
from
b867453 to
e133d2d
Compare
hessjcg
commented
Mar 10, 2025
| }, | ||
| serverCaCert: { | ||
| cert: CA_CERT, | ||
| t.test( |
Collaborator
Author
There was a problem hiding this comment.
When we changed the changes the cache behavior so that it caches using the cache key
{ domain/instance, ipType, iamEnabled }, the test changed too.
| ); | ||
| }); | ||
|
|
||
| t.test('Connector factory method mismatch auth type', async t => { |
Collaborator
Author
There was a problem hiding this comment.
When we changed the cache key, this test is no longer valid.
hessjcg
force-pushed
the
gh-421-dns-config
branch
2 times, most recently
from
0fe1de1 to
8b53b78
Compare
hessjcg
force-pushed
the
gh-421-dns-configuration
branch
from
303333c to
347eb71
Compare
hessjcg
force-pushed
the
gh-421-dns-config
branch
from
8b53b78 to
934dda4
Compare
wip: check for domain changed on connect. refactor: Config has separate fields for instanceConnectionName and domainName wip: periodic check for domain change wip: periodic checks wip: close sockets on instance closed
hessjcg
force-pushed
the
gh-421-dns-config
branch
from
934dda4 to
5be35f5
Compare
jackwotherspoon
approved these changes
Mar 17, 2025
Collaborator
jackwotherspoon
left a comment
jackwotherspoon
left a comment
There was a problem hiding this comment.
LGTM ✅ (Node Connector interface is slowly starting to look more similar to other connectors 🎉 )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The connector may be configured to use a DNS name to look up the instance
name instead of configuring the connector with the instance name directly.
Add a DNS TXT record for the Cloud SQL instance to a private DNS server
or a private Google Cloud DNS Zone used by your application. For example:
Record type: TXT
Name: prod-db.mycompany.example.com – This is the domain name used by the application
Value: my-project:region:my-instance – This is the instance connection name
Configure the dialer with the cloudsqlconn.WithDNSResolver() option.
Open a database connection using the DNS name:
Part of #421
See also: GoogleCloudPlatform/cloud-sql-go-connector#843