Skip to content

docs: Add Cloud Run and Node JS connector examples#506

Merged
kgala2 merged 6 commits intomainfrom
cloudrun-samples
Nov 25, 2025
Merged

docs: Add Cloud Run and Node JS connector examples#506
kgala2 merged 6 commits intomainfrom
cloudrun-samples

Conversation

@kgala2
Copy link
Copy Markdown
Contributor

@kgala2 kgala2 commented Nov 25, 2025

No description provided.

@kgala2 kgala2 requested a review from a team as a code owner November 25, 2025 18:59
Comment thread examples/cloudrun/knex/mysql2/index.cjs Fixed
Comment thread examples/cloudrun/knex/mysql2/index.cjs Fixed
Comment thread examples/cloudrun/knex/pg/index.mjs Fixed
Comment thread examples/cloudrun/knex/pg/index.mjs Fixed
Comment thread examples/cloudrun/knex/tedious/index.ts Fixed
Comment thread examples/cloudrun/sequelize/mysql2/index.ts Fixed
Comment thread examples/cloudrun/sequelize/mysql2/index.ts Fixed
Comment thread examples/cloudrun/sequelize/pg/index.cjs Fixed
Comment thread examples/cloudrun/sequelize/pg/index.cjs Fixed
Comment thread examples/cloudrun/sequelize/tedious/index.mjs Fixed
@kgala2 kgala2 marked this pull request as draft November 25, 2025 19:33
Copy link
Copy Markdown
Collaborator

@hessjcg hessjcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the functions as I described across all of the sample files. It think it will help our users understand the code.

Comment thread examples/cloudrun/knex/mysql2/index.cjs Outdated
Comment thread examples/cloudrun/knex/mysql2/index.cjs Outdated
Comment thread examples/cloudrun/knex/mysql2/index.cjs Outdated
Comment thread examples/cloudrun/knex/mysql2/index.cjs Outdated
Comment thread examples/cloudrun/knex/pg/index.mjs Dismissed
Comment thread examples/cloudrun/knex/pg/index.mjs Dismissed
Comment thread examples/cloudrun/sequelize/tedious/index.mjs Dismissed
@kgala2 kgala2 marked this pull request as ready for review November 25, 2025 21:27
@kgala2 kgala2 merged commit 53d3a44 into main Nov 25, 2025
28 checks passed
@kgala2 kgala2 deleted the cloudrun-samples branch November 25, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants