chore: update credential tests

Author: kgala2

tests/mysql_test.go

@@ -164,42 +164,36 @@ func TestMySQLAuthentication(t *testing.T) {
 		},
 	}
 	if *ipType == "public" {
-		tcs = append(tcs,
-			struct {
-				desc string
-				args []string
-			}{
+		additionaTcs := []struct {
+			desc string
+			args []string
+		}{
+			{
 				desc: "with credentials file",
 				args: []string{"--credentials-file", path, *mysqlConnName},
 			},
-			struct {
-				desc string
-				args []string
-			}{
+			{
 				desc: "with credentials file and impersonation",
 				args: []string{
 					"--credentials-file", path,
 					"--impersonate-service-account", *impersonatedUser,
-					*mysqlConnName},
+					*mysqlConnName,
+				},
 			},
-			struct {
-				desc string
-				args []string
-			}{
+			{
 				desc: "with credentials JSON",
 				args: []string{"--json-credentials", string(creds), *mysqlConnName},
 			},
-			struct {
-				desc string
-				args []string
-			}{
+			{
 				desc: "with credentials JSON and impersonation",
 				args: []string{
 					"--json-credentials", string(creds),
 					"--impersonate-service-account", *impersonatedUser,
-					*mysqlConnName},
+					*mysqlConnName,
+				},
 			},
-		)
+		}
+		tcs = append(tcs, additionaTcs...)
 	}
 	for _, tc := range tcs {
 		t.Run(tc.desc, func(t *testing.T) {

tests/postgres_test.go

@@ -148,42 +148,36 @@ func TestPostgresAuthentication(t *testing.T) {
 		},
 	}
 	if *ipType == "public" {
-		tcs = append(tcs,
-			[]struct {
-				desc string
-				args []string
-			}{
+		additionalTcs := []struct {
+			desc string
+			args []string
+		}{
+			{
 				desc: "with credentials file",
 				args: []string{"--credentials-file", path, *postgresConnName},
 			},
-			struct {
-				desc string
-				args []string
-			}{
+			{
 				desc: "with credentials file and impersonation",
 				args: []string{
 					"--credentials-file", path,
 					"--impersonate-service-account", *impersonatedUser,
-					*postgresConnName},
+					*postgresConnName,
+				},
 			},
-			struct {
-				desc string
-				args []string
-			}{
+			{
 				desc: "with credentials JSON",
 				args: []string{"--json-credentials", string(creds), *postgresConnName},
 			},
-			struct {
-				desc string
-				args []string
-			}{
+			{
 				desc: "with credentials JSON and impersonation",
 				args: []string{
 					"--json-credentials", string(creds),
 					"--impersonate-service-account", *impersonatedUser,
-					*postgresConnName},
+					*postgresConnName,
+				},
 			},
-		)
+		}
+		tcs = append(tcs, additionalTcs...)
 	}
 	for _, tc := range tcs {
 		t.Run(tc.desc, func(t *testing.T) {

tests/sqlserver_test.go

@@ -108,42 +108,36 @@ func TestSQLServerAuthentication(t *testing.T) {
 		},
 	}
 	if *ipType == "public" {
-		tcs = append(tcs,
-			[]struct {
-				desc string
-				args []string
-			}{
+		additionaTcs := []struct {
+			desc string
+			args []string
+		}{
+			{
 				desc: "with credentials file",
 				args: []string{"--credentials-file", path, *sqlserverConnName},
 			},
-			struct {
-				desc string
-				args []string
-			}{
+			{
 				desc: "with credentials file and impersonation",
 				args: []string{
 					"--credentials-file", path,
 					"--impersonate-service-account", *impersonatedUser,
-					*sqlserverConnName},
+					*sqlserverConnName,
+				},
 			},
-			struct {
-				desc string
-				args []string
-			}{
+			{
 				desc: "with credentials JSON",
 				args: []string{"--json-credentials", string(creds), *sqlserverConnName},
 			},
-			struct {
-				desc string
-				args []string
-			}{
+			{
 				desc: "with credentials JSON and impersonation",
 				args: []string{
 					"--json-credentials", string(creds),
 					"--impersonate-service-account", *impersonatedUser,
-					*sqlserverConnName},
+					*sqlserverConnName,
+				},
 			},
-		)
+		}
+		tcs = append(tcs, additionaTcs...)
 	}
 	for _, tc := range tcs {
 		t.Run(tc.desc, func(t *testing.T) {