docs: update wait command help message#2401
Merged
jackwotherspoon merged 3 commits intoGoogleCloudPlatform:mainfrom Mar 7, 2025
Merged
docs: update wait command help message#2401jackwotherspoon merged 3 commits intoGoogleCloudPlatform:mainfrom
jackwotherspoon merged 3 commits intoGoogleCloudPlatform:mainfrom
Conversation
Collaborator
|
@sjeandeaux Thanks for the PR! 😄 All the docs in our So instead of updating the docs you will want to update the help message directly... Lines 331 to 340 in bfb63f5 |
Without --health-check or --prometheus, the server http does not start Signed-off-by: Stephane Jeandeaux <stephane.jeandeaux@gmail.com>
jackwotherspoon
requested changes
Mar 7, 2025
Collaborator
jackwotherspoon
left a comment
There was a problem hiding this comment.
One small nit, otherwise LGTM 👍
Co-authored-by: Jack Wotherspoon <jackwoth@google.com>
jackwotherspoon
approved these changes
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without --health-check or --prometheus, the server http does not start