Skip to content

chore: remove reference to min-ready #2419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackwotherspoon merged 4 commits into from
Apr 4, 2025
Merged

chore: remove reference to min-ready #2419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d92afac
Update healthcheck.go
dmarkwat Apr 2, 2025
9a62dc7
Update healthcheck_test.go
dmarkwat Apr 2, 2025
560cb90
Update proxy.go
dmarkwat Apr 2, 2025
8899d44
revert and update doc
dmarkwat Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,10 +179,7 @@ Health checks
- /readiness: Returns 200 status when the Proxy has started, has available
connections if max connections have been set with the --max-connections
flag, and when the Proxy can connect to all registered instances. Otherwise,
returns a 503 status. Optionally supports a min-ready query param (e.g.,
/readiness?min-ready=3) where the Proxy will return a 200 status if the
Proxy can connect successfully to at least min-ready number of instances. If
min-ready exceeds the number of registered instances, returns a 400.
returns a 503 status.

- /liveness: Always returns 200 status. If this endpoint is not responding,
the Proxy is in a bad state and should be restarted.
Expand Down
5 changes: 1 addition & 4 deletions docs/cmd/cloud-sql-proxy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,7 @@ Health checks
- /readiness: Returns 200 status when the Proxy has started, has available
connections if max connections have been set with the --max-connections
flag, and when the Proxy can connect to all registered instances. Otherwise,
returns a 503 status. Optionally supports a min-ready query param (e.g.,
/readiness?min-ready=3) where the Proxy will return a 200 status if the
Proxy can connect successfully to at least min-ready number of instances. If
min-ready exceeds the number of registered instances, returns a 400.
returns a 503 status.

- /liveness: Always returns 200 status. If this endpoint is not responding,
the Proxy is in a bad state and should be restarted.
Expand Down
5 changes: 1 addition & 4 deletions examples/k8s-health-check/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,7 @@ the proxy is in a bad state and should be restarted.
- `/readiness`: Returns 200 status when the proxy has started, has available
connections if max connections have been set with the `--max-connections`
flag, and when the proxy can connect to all registered instances. Otherwise,
returns a 503 status. Optionally supports a min-ready query param (e.g.,
`/readiness?min-ready=3`) where the proxy will return a 200 status if the
proxy can connect successfully to at least min-ready number of instances. If
min-ready exceeds the number of registered instances, returns a 400.
returns a 503 status.


To configure the address, use `--http-address`. To configure the port, use
Expand Down
Loading