feat: add flag for ignoring bad connections#2452
Merged
hessjcg merged 5 commits intoGoogleCloudPlatform:mainfrom Jun 23, 2025
Merged
feat: add flag for ignoring bad connections#2452hessjcg merged 5 commits intoGoogleCloudPlatform:mainfrom
hessjcg merged 5 commits intoGoogleCloudPlatform:mainfrom
Conversation
kenkania
changed the title
kenkania
force-pushed
the
ignore-bad-conn-ken
branch
from
b638f45 to
d7ef453
Compare
enocom
reviewed
Jun 17, 2025
Contributor
Author
|
Thanks for the review! I've addressed all your comments, PTAL. |
Contributor
Author
|
@kgala2 can you run the integration tests for this PR? I see the failure says: "Needs /gcbrun from a collaborator" |
Contributor
|
/gcbrun |
Contributor
|
/gcbrun |
hessjcg
approved these changes
Jun 23, 2025
Collaborator
hessjcg
left a comment
hessjcg
left a comment
There was a problem hiding this comment.
Nice work, this looks good. Thank you for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port
skip-failed-instance-configfrom v1 to v2. If set, this will ignore connection errors instead of exiting on startup. See more use case details in associated issue.fixes #2451