feat: Use the proxy v2 engine but keep CLI flags unchanged.#2583
Draft
feat: Use the proxy v2 engine but keep CLI flags unchanged.#2583
Conversation
28a434e to
5720bfb
Compare
Cloud SQL Auth Proxy v1 will internally use Proxy V2 by default. This will allow Auth Proxy V2 users to benefit from the improved compatibility with Cloud SQL services (for example, connecting to MySQL with caching_sha2_password) without any updates to their proxy configuration. Customers may fall back to the legacy Proxy v1 code by adding the -legacy-v1-proxy flag. The proxy will automatically fall back to legacy Proxy v1 code if flags are used that are unsupported by Proxy v2, for example: -projects, -instances_metadata. This also adds an end-to-end test suite in proxy-v1/translatev2/translatev2_test.go that verifies: - Parity: Every test case runs in both translated_v2 and legacy_v1 modes to ensure identical behavior. - Database Support: Verified connectivity for MySQL, PostgreSQL, and SQL Server. - Auth Methods: Validated Password Auth, IAM Auth, and CAS/MCP instance types. - Connection Types: Tested TCP, Unix sockets, and FUSE (on supported platforms). - Edge Cases: Used URL-style DSNs to ensure special characters in IAM usernames are handled correctly across both modes.
5720bfb to
75a2672
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloud SQL Auth Proxy v1 will internally use Proxy V2 by default. This will allow Auth Proxy V2 users to benefit from the improved compatibility with Cloud SQL services (for example, connecting to MySQL with caching_sha2_password) without any updates to their proxy configuration.
Customers may fall back to the legacy Proxy v1 code by adding the
-legacy-v1-proxyflag.The proxy will automatically fall back to legacy Proxy v1 code if flags are used that are unsupported by Proxy v2, for example: -projects, -instances_metadata.
This also adds an end-to-end test suite in proxy-v1/translatev2/translatev2_test.go that verifies:
These are the V1 flags that are not directly supported by the v2 proxy, and the expected behavior.
-projects-instances_metadata-check_region-fd_rlimit-refresh_config_throttle