Add rule_custom_name variable to PSC endpoints bare targets#110
Open
crrlcx wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
Open
Add rule_custom_name variable to PSC endpoints bare targets#110crrlcx wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
crrlcx wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the naming convention for Private Service Connect (PSC) resources in the
psc_forwarding_ruleTerraform module. The main change is to allow more flexible and descriptive custom names for PSC compute addresses and forwarding rules by introducing a new optional variable,rule_custom_name, which defaults to"custom".Naming improvements for PSC resources:
rule_custom_nameto thepsc_endpointsvariable definition, allowing users to specify a custom name base for PSC resources.google_compute_address.psc_addressandgoogle_compute_forwarding_rule.psc_forwarding_ruleresources to userule_custom_name(with the index as a suffix) instead of a hardcoded"custom"base when neither a CloudSQL nor AlloyDB instance name is present. [1] [2]