fix(job): address PR feedback on mount flag and options parsing

Author: Neelabh94

cmd/job/submit.go

@@ -137,7 +137,7 @@ func init() {
 	SubmitCmd.Flags().StringVarP(&dryRunManifest, "dry-run-out", "o", "", "Path to output the generated Kubernetes manifest instead of applying it.")
 	SubmitCmd.Flags().StringVarP(&platform, "platform", "f", "linux/amd64", "Target platform for the image build (e.g., 'linux/amd64', 'linux/arm64'). Used with --base-image.")
 
-	SubmitCmd.Flags().StringSliceVar(&volumeStr, "mount", nil, "Volumes to mount (format: <src>;<dest>[;<mode>][;options=<options>], mode can be 'ro' or 'rw', default 'ro').")
+	SubmitCmd.Flags().StringArrayVar(&volumeStr, "mount", nil, "Volumes to mount (format: <src>;<dest>[;<mode>][;options=<options>], mode can be 'ro' or 'rw', default 'ro').")
 
 	SubmitCmd.Flags().StringArrayVar(&envVars, "env", []string{}, "Custom environment variables to pass to the workload container in KEY=VALUE format. Can be specified multiple times.")
 

pkg/orchestrator/gke/storage.go

@@ -71,9 +71,7 @@ func (sm *StorageManager) ProcessMounts(mounts []string, job orchestrator.JobDef
 			MountPath: dest,
 			Type:      volType,
 			ReadOnly:  readOnly,
-		}
-		if volType == "gcsfuse" {
-			mountInfo.Options = options
+			Options:   options,
 		}
 		mountInfos = append(mountInfos, mountInfo)
 	}

pkg/orchestrator/gke/storage_test.go

@@ -188,6 +188,14 @@ func TestParseSingleVolume(t *testing.T) {
 			wantErr:    true,
 			wantErrSub: "options= is currently only supported for GCS",
 		},
+		{
+			name:     "valid gcsfuse with multiple comma-separated options",
+			input:    "gs://my-bucket;/data;options=logging:severity:info,enable-atomic-rename-object:true",
+			wantSrc:  "gs://my-bucket",
+			wantDest: "/data",
+			wantRO:   true,
+			wantOpts: "logging:severity:info,enable-atomic-rename-object:true",
+		},
 	}
 
 	for _, tc := range tests {