feat(job): Rename --gcsfuse-mount-options to --mount-options, add validation and update docs

Author: Neelabh94

cmd/job/submit.go

@@ -79,7 +79,7 @@ var (
 	pathwaysWorkerEnv []string
 	validEnvKeyRegex  = regexp.MustCompile("^[a-zA-Z_][a-zA-Z0-9_]*$")
 
-	gcsfuseMountOptions string
+	mountOptions      string
 )
 
 var SubmitCmd = &cobra.Command{
@@ -125,6 +125,14 @@ and JobSet/Kueue specific configurations like workload name, queue, nodes, and r
 
 		priorityClassName = strings.ToLower(priorityClassName)
 
+		if mountOptions != "" {
+			for _, m := range volumeStr {
+				if !strings.HasPrefix(m, "gs://") {
+					return fmt.Errorf("--mount-options is currently only supported for GCS fuse volumes (gs://...)")
+				}
+			}
+		}
+
 		return nil
 	},
 	SilenceUsage: true,
@@ -140,6 +148,7 @@ func init() {
 	SubmitCmd.Flags().StringVarP(&platform, "platform", "f", "linux/amd64", "Target platform for the image build (e.g., 'linux/amd64', 'linux/arm64'). Used with --base-image.")
 
 	SubmitCmd.Flags().StringSliceVar(&volumeStr, "mount", nil, "Volumes to mount (format: <src>:<dest>[:<mode>], mode can be 'ro' or 'rw', default 'ro').")
+	SubmitCmd.Flags().StringVar(&mountOptions, "mount-options", "", "Mount options for all volumes (currently only supported for GCS fuse volumes, e.g., 'logging:severity:info,enable-atomic-rename-object:true').")
 	SubmitCmd.Flags().StringArrayVar(&envVars, "env", []string{}, "Custom environment variables to pass to the workload container in KEY=VALUE format. Can be specified multiple times.")
 
 	SubmitCmd.Flags().StringVarP(&workloadName, "name", "n", "", "Name of the workload to create. Required.")
@@ -165,7 +174,6 @@ func init() {
 	SubmitCmd.Flags().BoolVar(&verbose, "verbose", false, "Enable verbose logging for the workload (TPUs and GPUs).")
 	SubmitCmd.Flags().StringVar(&gkeNapProvisioning, "gke-nap-provisioning", "", "Compute provisioning model for GKE NAP. Allowed values: on-demand, spot, reservation.")
 	SubmitCmd.Flags().StringVar(&gkeNapReservation, "gke-nap-reservation", "", "Name of the Google Cloud Reservation for GKE NAP (required if --gke-nap-provisioning=reservation).")
-	SubmitCmd.Flags().StringVar(&gcsfuseMountOptions, "gcsfuse-mount-options", "", "GCSFuse mount options for all GCS mounts (e.g., 'logging:severity:info,enable-atomic-rename-object:true').")
 
 	SubmitCmd.Flags().BoolVar(&isPathwaysJob, "pathways", false, "If present, gcluster will generate a manifest for a Pathways job.")
 	SubmitCmd.Flags().StringVar(&pathways.ProxyServerImage, "pathways-proxy-server-image", "", "The image for the Pathways proxy server.")
@@ -261,7 +269,7 @@ func runSubmitCmd(cmd *cobra.Command, args []string) error {
 		IsPathwaysJob:                 isPathwaysJob,
 		Pathways:                      pathways,
 		RawMounts:                     volumeStr,
-		GCSFuseMountOptions:           gcsfuseMountOptions,
+		MountOptions:                  mountOptions,
 		Env:                           parseEnvFlags(envVars),
 		Verbose:                       verbose,
 	}

docs/gcluster_job_guide.md

@@ -164,6 +164,8 @@ You can mount Cloud Storage buckets, Filestore instances, existing PVCs (e.g., f
 Mounts must use the format: `--mount "<src>:<dest>[:<mode>]"`
 * `mode` is optional and defaults to `ro` (read-only). To allow writes, append `:rw`.
 
+You can also pass custom mount options to GCS fuse volumes using the `--mount-options` flag.
+
 **Supported volume sources (`<src>`):**
 * **Cloud Storage**: `gs://<bucket-name>` (mounts via GCS Fused Driver)
 * **Filestore**: `filestore://<instance-name-or-ip>/<share-name>` (auto-provisions PV and PVC)
@@ -187,7 +189,8 @@ Mounting a GCS bucket (read-write):
   --compute-type n2-standard-32 \
   --base-image python:3.9-slim \
   --build-context job_details \
-  --mount "gs://<YOUR_BUCKET_NAME>:/data:rw"
+  --mount "gs://<YOUR_BUCKET_NAME>:/data:rw" \
+  --mount-options "logging:severity:info,enable-atomic-rename-object:true"
 ```
 
 Mounting an existing PVC named `lustre-pvc` (read-only):
@@ -1095,6 +1098,7 @@ The `gcluster job submit` command deploys a container image as a job (Kubernetes
 | `--num-nodes` | `int` | Number of nodes to use per group/slice (Default: `1`). Auto-calculated for TPUs based on topology. |
 | `--restarts` | `int` | Maximum number of restarts allowed for the JobSet before marked as failed (Default: `1`). |
 | `--mount` | `stringArray` | Mount storage volumes, buckets, filestore instances, or PVCs using the `<src>:<dest>[:<mode>]` format. Examples of `<src>`: `gs://my-bucket`, `filestore://my-instance/share`, `my-pvc` (for Lustre/etc), or `/host/path`. |
+| `--mount-options` | `string` | Custom mount options for attached volumes (currently only supported for GCS fuse volumes, e.g., `logging:severity:info,enable-atomic-rename-object:true`). |
 | `--env` | `stringArray` | Custom environment variables to pass exclusively to the user's workload container in KEY=VALUE format (e.g. `--env KEY=VALUE`). Applies to both standard and Pathways workloads. Can be specified multiple times. |
 | `--await-job-completion` | `bool` | If true, the CLI waits for the job to complete before exiting. |
 | `--timeout` | `string` | Time to wait for job completion (e.g., `1h`, `10m`). Used with `--await-job-completion`. |

pkg/orchestrator/gke/storage.go

@@ -73,7 +73,7 @@ func (sm *StorageManager) ProcessMounts(mounts []string, job orchestrator.JobDef
 			ReadOnly:  readOnly,
 		}
 		if volType == "gcsfuse" {
-			mountInfo.Options = job.GCSFuseMountOptions
+			mountInfo.Options = job.MountOptions
 		}
 		mountInfos = append(mountInfos, mountInfo)
 	}

pkg/orchestrator/orchestrator.go

@@ -99,7 +99,7 @@ type JobDefinition struct {
 	Pathways      PathwaysJobDefinition // Embedded struct for Pathways-specific args
 
 	RawMounts           []string
-	GCSFuseMountOptions string
+	MountOptions string
 	Env                 map[string]string
 
 	Verbose bool