Updated reservation_definitions.tf for more precise cpu validation

Author: agrawalkhushi18

modules/compute/gke-node-pool/reservation_definitions.tf

@@ -57,13 +57,19 @@ locals {
 
   # Build two maps to be used to compare the VM properties between reservations and the node pool
   # Skip this for TPUs
-  reservation_vm_properties = local.has_gpu ? ([for reservation in local.verified_specific_reservations : {
+  # Validation of only machine-type for CPUs and and both machine-type and guest-accelerators for GPUs
+  reservation_vm_properties = [for reservation in local.verified_specific_reservations : {
     "machine_type" : try(reservation.specific_reservation[0].instance_properties[0].machine_type, "")
-    "guest_accelerators" : { for acc in try(reservation.specific_reservation[0].instance_properties[0].guest_accelerators, []) : acc.accelerator_type => acc.accelerator_count }
-  }]) : []
+    "guest_accelerators" : local.has_gpu ? ( # Conditional check for GPUs
+      { for acc in try(reservation.specific_reservation[0].instance_properties[0].guest_accelerators, []) : acc.accelerator_type => acc.accelerator_count }
+    ) : {} # If no GPUs, it's an empty map {}
+  }]
+
   nodepool_vm_properties = {
     "machine_type" : var.machine_type
-    "guest_accelerators" : { for acc in try(local.guest_accelerator, []) : coalesce(acc.type, try(local.generated_guest_accelerator[0].type, "")) => coalesce(acc.count, try(local.generated_guest_accelerator[0].count, 0)) }
+    "guest_accelerators" : local.has_gpu ? ( # Conditional check for GPUs
+      { for acc in try(local.guest_accelerator, []) : coalesce(acc.type, try(local.generated_guest_accelerator[0].type, "")) => coalesce(acc.count, try(local.generated_guest_accelerator[0].count, 0)) }
+    ) : {} # If no GPUs, it's an empty map {}
   }
 
   # Compare two maps by counting the keys that mismatch.