address gemini review

Author: sudheer-quad

tools/cloud-build/check_retriable_error.sh

@@ -21,6 +21,11 @@ if [ -z "$LOG_FILE" ]; then
 	exit 2
 fi
 
+if [ ! -f "$LOG_FILE" ]; then
+	echo "Error: Log file '$LOG_FILE' does not exist or is not a regular file." >&2
+	exit 2
+fi
+
 # Define all retriable errors here.
 # Note: "Couldn't find a zone to deploy" and "ERROR: ZONE not found" are not included here
 # because find_available_zone.sh now internally loops and waits for zone capacity to maintain Kueue locks.

tools/cloud-build/daily-tests/builds/slurm-gcp-v6-rocky8.yaml

@@ -51,7 +51,7 @@ steps:
 - id: generate-job-manifest
   name: gcr.io/cloud-builders/gcloud
   entrypoint: /bin/bash
-  secretEnv: ['GCLUSTER_GCS_PATH', 'SA_EMAIL']
+  secretEnv: ['GCLUSTER_GCS_PATH', 'SA_EMAIL', 'TRIAGE_GCS_BUCKET', 'TRIAGE_PROJECT_NUMBER', 'TRIAGE_INVOKER_SA', 'TRIAGE_CLOUD_RUN_URL']
   args:
   - -c
   - |
@@ -258,7 +258,6 @@ steps:
   - -c
   - |
     gcloud artifacts docker images delete us-central1-docker.pkg.dev/$PROJECT_ID/hpc-toolkit-repo/test-runner:$BUILD_ID --quiet
-  secretEnv: ['GCLUSTER_GCS_PATH', 'TRIAGE_GCS_BUCKET', 'TRIAGE_PROJECT_NUMBER', 'TRIAGE_INVOKER_SA', 'TRIAGE_CLOUD_RUN_URL', 'SA_EMAIL']
 availableSecrets:
   secretManager:
   - versionName: projects/${PROJECT_ID}/secrets/gcluster-develop-release-bucket/versions/latest

tools/cloud-build/wait_for_available_zone.sh

@@ -21,10 +21,11 @@ while true; do
 	# To extract the exported variables, we have the subshell write them to a file.
 	set +e
 	(
-		source /workspace/tools/cloud-build/find_available_zone.sh
+		set -e
+	    source /workspace/tools/cloud-build/find_available_zone.sh
 		# If it succeeds, these lines will execute and save the exports.
-		echo "export ZONE=${ZONE}" >/tmp/zone_export.sh
-		echo "export PROVISIONING_MODEL=${PROVISIONING_MODEL}" >>/tmp/zone_export.sh
+		echo "export ZONE=\"${ZONE}\"" >/tmp/zone_export.sh
+		echo "export PROVISIONING_MODEL=\"${PROVISIONING_MODEL}\"" >>/tmp/zone_export.sh
 	) 2>&1 | tee /tmp/zone_output.log
 
 	EXIT_CODE=${PIPESTATUS[0]}