Skip to content

exposing network project id#5669

Draft
kadupoornima wants to merge 2 commits into
GoogleCloudPlatform:developfrom
kadupoornima:vpc-packer
Draft

exposing network project id#5669
kadupoornima wants to merge 2 commits into
GoogleCloudPlatform:developfrom
kadupoornima:vpc-packer

Conversation

@kadupoornima

@kadupoornima kadupoornima commented May 15, 2026

Copy link
Copy Markdown
Contributor

This pull request enhances the network modules by exposing the project ID associated with VPC networks and subnetworks. By adding these as output variables, users gain better visibility into the infrastructure state. Additionally, the custom image module was updated to allow for more flexible project ID configuration during image building, ensuring better compatibility with cross-project network deployments.

Changes:

  • Network Project ID Exposure: Added 'network_project_id' and 'subnetwork_project_id' outputs across multiple network modules to improve visibility into the project context of provisioned resources.
  • Packer Custom Image Enhancement: Updated the custom image module to support 'subnetwork_project_id' and improved the logic for setting 'network_project_id' in the Packer configuration.
  • Documentation Updates: Regenerated documentation for all modified modules to reflect the new output variables and input parameters.

@kadupoornima
kadupoornima requested a review from a team as a code owner May 15, 2026 06:43
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the network modules by exposing the project ID associated with VPC networks and subnetworks. By adding these as output variables, users gain better visibility into the infrastructure state. Additionally, the custom image module was updated to allow for more flexible project ID configuration during image building, ensuring better compatibility with cross-project network deployments.

Highlights

  • Network Project ID Exposure: Added 'network_project_id' and 'subnetwork_project_id' outputs across multiple network modules to improve visibility into the project context of provisioned resources.
  • Packer Custom Image Enhancement: Updated the custom image module to support 'subnetwork_project_id' and improved the logic for setting 'network_project_id' in the Packer configuration.
  • Documentation Updates: Regenerated documentation for all modified modules to reflect the new output variables and input parameters.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@kadupoornima kadupoornima added the release-module-improvements Added to release notes under the "Module Improvements" heading. label May 15, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several network modules—including gpu-rdma-vpc, multivpc, pre-existing-subnetwork, pre-existing-vpc, and vpc—to provide project ID outputs for both networks and subnetworks. The packer/custom-image module is also updated to include a subnetwork_project_id input, which serves as a fallback for network_project_id. Furthermore, the README documentation for these modules has been refreshed with standardized table formatting and updated input/output definitions. I have no feedback to provide as there were no review comments to assess.

@kadupoornima
kadupoornima requested a review from arpit974 May 15, 2026 06:52
@kadupoornima
kadupoornima marked this pull request as draft May 20, 2026 06:59
@cboneti cboneti assigned arpit974 and kadupoornima and unassigned arpit974 Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-module-improvements Added to release notes under the "Module Improvements" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants