Skip to content

Pin DCGM version for a4xmax#5958

Merged
saumyasharma03 merged 1 commit into
GoogleCloudPlatform:developfrom
saumyasharma03:pin-dcgm-a4xmax
Jul 22, 2026
Merged

Pin DCGM version for a4xmax#5958
saumyasharma03 merged 1 commit into
GoogleCloudPlatform:developfrom
saumyasharma03:pin-dcgm-a4xmax

Conversation

@saumyasharma03

@saumyasharma03 saumyasharma03 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Pin DCGM version for A4XMax
Completed NCCL testing, DCGM diagnostics level 1, checked nvidia-dcgmi status, nvidia smi and other basic slurm commands.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request stabilizes the A4XMax deployment environment by explicitly pinning DCGM package versions. It also improves the robustness of the deployment automation by adjusting how packages are marked for holding, ensuring compatibility with version-specific package strings.

Highlights

  • Version Pinning: Pinned the DCGM (Datacenter GPU Manager) packages to version 1:4.6.0-1 for the A4XMax configuration to ensure environment consistency.
  • Apt-mark adjustment: Updated the package holding logic to correctly parse package names by splitting the version string, ensuring that pinned packages are handled properly during deployment.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@saumyasharma03 saumyasharma03 added the release-version-updates Added to release notes under the "Version Updates" heading. label Jul 16, 2026
@github-actions github-actions Bot added the external PR from external contributor label Jul 16, 2026
@saumyasharma03 saumyasharma03 self-assigned this Jul 16, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the a4xmax-bm-slurm-blueprint.yaml blueprint to pin specific versions (1:4.6.0-1) for the datacenter-gpu-manager packages (cuda13, dev, and the newly added core). Additionally, it updates the apt-mark hold task to split the package name from its version string using item.split('=')[0] to ensure the package hold is applied correctly. There are no review comments, and I have no additional feedback to provide.

@aslam-quad aslam-quad removed the external PR from external contributor label Jul 16, 2026
@saumyasharma03
saumyasharma03 requested a review from arpit974 July 20, 2026 07:57
@saumyasharma03
saumyasharma03 marked this pull request as ready for review July 20, 2026 07:57
@saumyasharma03
saumyasharma03 requested a review from a team as a code owner July 20, 2026 07:57
@Neelabh94 Neelabh94 assigned arpit974 and unassigned saumyasharma03 Jul 21, 2026
@arpit974 arpit974 assigned saumyasharma03 and unassigned arpit974 Jul 22, 2026
@saumyasharma03
saumyasharma03 merged commit 75331e8 into GoogleCloudPlatform:develop Jul 22, 2026
26 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-version-updates Added to release notes under the "Version Updates" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants