Skip to content

fix(validation): Resolve PSA collisions in base integration tests#5983

Open
shubpal07 wants to merge 1 commit into
GoogleCloudPlatform:developfrom
shubpal07:shubham/fix-base-playbook-psa
Open

fix(validation): Resolve PSA collisions in base integration tests#5983
shubpal07 wants to merge 1 commit into
GoogleCloudPlatform:developfrom
shubpal07:shubham/fix-base-playbook-psa

Conversation

@shubpal07

Copy link
Copy Markdown
Contributor

Apply the PSA cleanup and variable scope fixes to the base integration test playbook (base-integration-test.yml). This ensures GKE and other non-Slurm tests can also resolve static VPC names, clean up stale PSA connections pre-deployment, and correctly target them during failure recovery/rescue.

@shubpal07
shubpal07 requested a review from a team as a code owner July 21, 2026 08:51
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the reliability of base integration tests by implementing proactive cleanup of stale PSA resources and standardizing network variable scoping. These changes ensure that test environments are properly initialized and that infrastructure deployment remains resilient against previous run artifacts.

Highlights

  • PSA Resource Cleanup: Added a mandatory cleanup task for existing Private Service Access (PSA) resources before infrastructure deployment to prevent naming collisions.
  • Dynamic Network Resolution: Introduced the 'actual_network' variable to ensure consistent network identification across various test scenarios, including GKE and non-Slurm configurations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an 'actual_network' variable in the Ansible integration test playbook to dynamically determine the network name and adds a task to clean up existing PSA resources. The review feedback recommends applying the '| bool' filter to the 'use_fixed_vpc' variable in the Jinja2 conditional to ensure it is correctly evaluated as a boolean.

Comment thread tools/cloud-build/daily-tests/ansible_playbooks/base-integration-test.yml Outdated
@shubpal07
shubpal07 requested a review from LAVEEN July 21, 2026 08:55
@shubpal07 shubpal07 added the release-chore To not include into release notes label Jul 21, 2026
…valuation

- Apply PSA cleanup and variable scope fixes to `base-integration-test.yml` to resolve collisions in GKE/Lustre tests.
- Add `| bool` filter to `use_fixed_vpc` evaluation in both base and Slurm playbooks to ensure string representations of booleans are correctly parsed.
- Simplify firewall rule network parameter in base playbook to use `actual_network` directly.

Change-Id: I35699c046cb1bdcb837e678f01692929180a3ffc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants