fix(validation): Resolve PSA collisions in base integration tests#5983
fix(validation): Resolve PSA collisions in base integration tests#5983shubpal07 wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the reliability of base integration tests by implementing proactive cleanup of stale PSA resources and standardizing network variable scoping. These changes ensure that test environments are properly initialized and that infrastructure deployment remains resilient against previous run artifacts. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces an 'actual_network' variable in the Ansible integration test playbook to dynamically determine the network name and adds a task to clean up existing PSA resources. The review feedback recommends applying the '| bool' filter to the 'use_fixed_vpc' variable in the Jinja2 conditional to ensure it is correctly evaluated as a boolean.
…valuation - Apply PSA cleanup and variable scope fixes to `base-integration-test.yml` to resolve collisions in GKE/Lustre tests. - Add `| bool` filter to `use_fixed_vpc` evaluation in both base and Slurm playbooks to ensure string representations of booleans are correctly parsed. - Simplify firewall rule network parameter in base playbook to use `actual_network` directly. Change-Id: I35699c046cb1bdcb837e678f01692929180a3ffc
8cc76a7 to
a90efef
Compare
Apply the PSA cleanup and variable scope fixes to the base integration test playbook (
base-integration-test.yml). This ensures GKE and other non-Slurm tests can also resolve static VPC names, clean up stale PSA connections pre-deployment, and correctly target them during failure recovery/rescue.