Skip to content

Update NCCL Jobset image in GKE A4X Max#6007

Merged
parulbajaj01 merged 1 commit into
GoogleCloudPlatform:developfrom
parulbajaj01:nccl
Jul 24, 2026
Merged

Update NCCL Jobset image in GKE A4X Max#6007
parulbajaj01 merged 1 commit into
GoogleCloudPlatform:developfrom
parulbajaj01:nccl

Conversation

@parulbajaj01

Copy link
Copy Markdown
Contributor

This PR is to update the image used in nccl-jobset-example.yaml in gke a4x max blueprint.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@parulbajaj01
parulbajaj01 requested a review from Neelabh94 July 24, 2026 06:41
@parulbajaj01
parulbajaj01 requested a review from a team as a code owner July 24, 2026 06:41
@parulbajaj01 parulbajaj01 added the release-chore To not include into release notes label Jul 24, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the container image reference used in the NCCL jobset example for the GKE A4X Max blueprint. This change ensures that the deployment utilizes the latest version of the diagnostic-enabled image, maintaining consistency with current infrastructure requirements.

Highlights

  • Container Image Update: Updated the container image for the NCCL jobset example in the GKE A4X Max blueprint from v1.1.1 to v1.1.2.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the container image for the nccl-test container in the nccl-jobset-example.yaml example file, upgrading it from nccl-gib-a4x-max-arm64:v1.1.1 to nccl-plugin-gib-diagnostic-arm64:v1.1.2. No review comments were provided, and there is no additional feedback to address.

@Neelabh94 Neelabh94 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parulbajaj01
parulbajaj01 merged commit 3d418d9 into GoogleCloudPlatform:develop Jul 24, 2026
15 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants