Skip to content

Remove pre-commit validation for daily test builds - #6011

Merged
sudheer-quad merged 1 commit into
GoogleCloudPlatform:developfrom
sudheer-quad:rm-precommit-daily-builds
Jul 28, 2026
Merged

Remove pre-commit validation for daily test builds#6011
sudheer-quad merged 1 commit into
GoogleCloudPlatform:developfrom
sudheer-quad:rm-precommit-daily-builds

Conversation

@sudheer-quad

@sudheer-quad sudheer-quad commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

This PR removes validate daily builds test pre-commit hook, the check_for_running_build pre-commit hook blocked renaming or modifying build files as a part of daily tests Kueue migration. So, removing the check to unblock development.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request removes the daily test build validation pre-commit hook. This change is intended to unblock development by removing restrictions that prevented the modification or renaming of build files during the Kueue migration process.

Highlights

  • Removal of Pre-commit Hook: The 'validate-daily-test-builds' pre-commit hook has been removed from the .pre-commit-config.yaml file.
  • Cleanup of Validation Script: The associated validation script 'tools/cloud-build/daily-tests/validate_daily_test_builds.py' has been deleted as it is no longer required.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions Bot added the external PR from external contributor label Jul 27, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the "validate-daily-test-builds" pre-commit hook from ".pre-commit-config.yaml" and deletes the associated Python validation script. There are no review comments, so I have no feedback to provide.

@sudheer-quad
sudheer-quad marked this pull request as ready for review July 27, 2026 12:21
@sudheer-quad
sudheer-quad requested a review from a team as a code owner July 27, 2026 12:21
@sudheer-quad sudheer-quad added the release-chore To not include into release notes label Jul 27, 2026

@Neelabh94 Neelabh94 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Neelabh94 Neelabh94 assigned rahimkhan19 and unassigned Neelabh94 Jul 28, 2026
@sudheer-quad
sudheer-quad merged commit f2a80f9 into GoogleCloudPlatform:develop Jul 28, 2026
16 of 82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external PR from external contributor release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants