Revert "Pin DCGM version for A3H" - #6013
Conversation
This reverts commit ea89d08.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request reverts a previous change that pinned specific versions of the Datacenter GPU Manager (DCGM) for the A3 high-GPU configuration. By removing these constraints, the deployment will now pull the latest available versions, and the associated Ansible tasks have been simplified to reflect this change. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request simplifies the NVIDIA package installation in the Slurm blueprint by removing specific version constraints for the datacenter GPU manager packages and adjusting the package freezing task. The review feedback recommends optimizing the Ansible apt task by passing the package list directly to the name parameter instead of looping, which avoids redundant cache updates, and maintaining consistency with the repository's boolean style by using 'yes' instead of 'true'.
Reverts #5957