fix: correct integration test assertions for postgresql create#144
Open
tpwo wants to merge 1 commit into
Open
Conversation
Two bugs in assert_environment_directories_exist: - "plugins" was in the initial required_dirs list AND conditionally appended, causing it to appear twice when plugins_path is not provided - "airflow.db" was expected but postgresql engine creates ".keep" (sqlite3 creates airflow.db); all three tests use the postgresql default - "postgresql_data" directory was not expected but is created by create_database_files() for postgresql engine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two problems in
assert_environment_directories_exist:New PR
Thank you for contributing!
developmentbranch, pleasemake sure you set it as the target of this PR.
pytest testsand all the unit tests are green.