Migrate gsutil usage to gcloud storage by bhandarivijay-png · Pull Request #2607 · GoogleCloudPlatform/compute-image-tools

bhandarivijay-png · 2025-12-24T16:53:20Z

Migrate gsutil usage to gcloud storage

google-oss-prow · 2025-12-24T16:53:43Z

Hi @bhandarivijay-png. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cadieuxnicolas51-cloud · 2026-01-22T04:50:52Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bhandarivijay-png
Once this PR has been reviewed and has the lgtm label, please assign dorileo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details
Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bkatyl · 2026-01-22T21:57:12Z

  Write-Output "Generating sbom."
  & "C:\sbomutil.exe" -archetype=windows-image -googet_path 'C:\ProgramData\GooGet' -extra_content="${script:sbom_dir}\" -comp_name="${comp_name}" -output image.sbom.json
-  & 'gsutil' -m cp image.sbom.json $gs_path
+  & 'gcloud storage cp image.sbom.json $gs_path


I believe a single quota is missing here.

bkatyl · 2026-01-22T22:00:31Z

  if ($gs_path) {
    Write-Output "Downloading components from $gs_path."
-    & 'gsutil' -m cp -r "${gs_path}/*" $script:components_dir
+    & 'gcloud storage cp -r "${gs_path}/*" $script:components_dir


I believe a single quota is missing here.

Line 70 is still missing a single quote

& 'gcloud storage cp -r "${gs_path}/" $script:components_dir
-->
& 'gcloud storage cp -r' "${gs_path}/" $script:components_dir

gurusai-voleti · 2026-05-22T13:16:15Z

@bkatyl can you review and merge this PR

bkatyl · 2026-05-26T03:18:37Z

@@ -51,7 +51,7 @@ function Download-Drivers {
  $gs_path = Get-MetadataValue -key 'drivers-path'
  if ($gs_path) {
    Write-Output "Downloading drivers from $gs_path."
-    & 'gsutil' -m cp -r "${gs_path}/*" $script:driver_dir
+    & 'gcloud storage' cp -r "${gs_path}/*" $script:driver_dir


This is inconsistent with the other changes. The other changes include the arguments in the literal string

'gcloud storage' cp
-->
'gcloud storage cp -r'

addressed in all places

@bkatyl can you merge this PR as well, we don't have permissions

bkatyl · 2026-05-26T03:19:34Z

  if ($gs_path) {
    Write-Output "Downloading components from $gs_path."
-    & 'gsutil' -m cp -r "${gs_path}/*" $script:components_dir
+    & 'gcloud storage cp -r "${gs_path}/*" $script:components_dir


Line 70 is still missing a single quote

& 'gcloud storage cp -r "${gs_path}/" $script:components_dir
-->
& 'gcloud storage cp -r' "${gs_path}/" $script:components_dir

Co-authored-by: Saswat Padhi <saswat.sourav@gmail.com>

google-oss-prow · 2026-06-09T09:19:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bhandarivijay-png, bkatyl, SaswatPadhi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [SaswatPadhi,bkatyl]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gurusai-voleti · 2026-06-09T09:26:39Z

@SaswatPadhi can you help merge it as well, we don't have permissions to merge

google-oss-prow · 2026-06-09T09:29:47Z

@bhandarivijay-png: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
prow/presubmit/sbom_windows	`aafa6b4`	link	true	`/sbom_windows`

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Migrate gsutil usage to gcloud storage

b57ee6f

google-oss-prow Bot added size/S needs-ok-to-test labels Dec 24, 2025

google-oss-prow Bot requested review from ChaitanyaKulkarni28 and bkatyl December 24, 2025 16:53

bkatyl reviewed Jan 22, 2026

View reviewed changes

chore: Migrate gsutil usage to gcloud storage

c5e8210

bhandarivijay-png force-pushed the compute-image-demo branch from 620da42 to c5e8210 Compare January 27, 2026 12:37

bkatyl reviewed May 26, 2026

View reviewed changes

gurusai-voleti added 2 commits May 26, 2026 09:33

Update bootstrap_install.ps1

994b97f

Update sql_install.ps1

c8e2494

bkatyl approved these changes May 26, 2026

View reviewed changes

google-oss-prow Bot assigned bkatyl May 26, 2026

google-oss-prow Bot added lgtm approved labels May 26, 2026

SaswatPadhi requested changes Jun 8, 2026

View reviewed changes

google-oss-prow Bot assigned SaswatPadhi Jun 8, 2026

google-oss-prow Bot removed the lgtm label Jun 8, 2026

gurusai-voleti and others added 9 commits June 9, 2026 09:39

Update daisy_workflows/image_build/sqlserver/sql_install.ps1

a88ac83

Co-authored-by: Saswat Padhi <saswat.sourav@gmail.com>

Update daisy_workflows/image_build/sqlserver/sql_install.ps1

308a447

Co-authored-by: Saswat Padhi <saswat.sourav@gmail.com>

Update daisy_workflows/image_build/sqlserver/sql_install.ps1

c9e8e74

Co-authored-by: Saswat Padhi <saswat.sourav@gmail.com>

Update daisy_workflows/image_build/sqlserver/sql_install.ps1

ce4af30

Co-authored-by: Saswat Padhi <saswat.sourav@gmail.com>

Update daisy_workflows/image_build/sqlserver/sql_install.ps1

ae3dd01

Co-authored-by: Saswat Padhi <saswat.sourav@gmail.com>

Update daisy_workflows/image_build/windows/bootstrap_install.ps1

8b227e4

Co-authored-by: Saswat Padhi <saswat.sourav@gmail.com>

Update daisy_workflows/image_build/windows/bootstrap_install.ps1

0410dfb

Co-authored-by: Saswat Padhi <saswat.sourav@gmail.com>

Update daisy_workflows/image_build/sqlserver/sql_install.ps1

07cb65b

Co-authored-by: Saswat Padhi <saswat.sourav@gmail.com>

Update daisy_workflows/image_build/windows/bootstrap_install.ps1

e4c606c

Co-authored-by: Saswat Padhi <saswat.sourav@gmail.com>

Update bootstrap_install.ps1

aafa6b4

SaswatPadhi approved these changes Jun 9, 2026

View reviewed changes

google-oss-prow Bot added the lgtm label Jun 9, 2026

Uh oh!

Conversation

bhandarivijay-png commented Dec 24, 2025

Uh oh!

google-oss-prow Bot commented Dec 24, 2025

Uh oh!

cadieuxnicolas51-cloud commented Jan 22, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gurusai-voleti commented May 22, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

google-oss-prow Bot commented Jun 9, 2026

Uh oh!

gurusai-voleti commented Jun 9, 2026

Uh oh!

google-oss-prow Bot commented Jun 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants