examples: correct pip-install package names in two tutorial notebooks#14
Open
x4v13r64 wants to merge 1 commit into
Open
examples: correct pip-install package names in two tutorial notebooks#14x4v13r64 wants to merge 1 commit into
x4v13r64 wants to merge 1 commit into
Conversation
* 04-wrapper-agents.ipynb installed google-cloud-dialogflow-v2beta1 which is not a real PyPI package. The Dialogflow client library is google-cloud-dialogflow; v2beta1 is the API version the package exposes as a google.cloud.dialogflow_v2beta1 submodule. * 07-wrapper-iam.ipynb installed google-cloud-resourcemanager (which is not the real package, the canonical name uses hyphens: google-cloud-resource-manager) and google-cloud-iam-admin (also not a real package, the iam_admin_v1 module is distributed by google-cloud-iam). The notebooks resolve correctly with the corrected names because both the dialogflow_v2beta1 and iam_admin_v1 modules referenced later in each notebook live inside the renamed packages.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two of the example notebooks instruct the user to
pip installpackage names that don't exist on PyPI.examples/04-wrapper-agents.ipynbinstallsgoogle-cloud-dialogflow-v2beta1. That name is unclaimed on PyPI. The actual Dialogflow client library is published asgoogle-cloud-dialogflow; it exposes the v2beta1 API surface as agoogle.cloud.dialogflow_v2beta1submodule, which is what the notebook later imports:examples/07-wrapper-iam.ipynbinstallsgoogle-cloud-resourcemanagerandgoogle-cloud-iam-admin. Both names are unclaimed on PyPI. The canonical packages use different naming:google-cloud-resource-manager(with hyphens between words).iam_admin_v1module is distributed by thegoogle-cloud-iampackage, not a separategoogle-cloud-iam-adminpackage.The notebook's embedded
iam.pyimports both modules from those packages:This PR replaces the three invalid names with the correct ones so the install cells actually resolve.