fix(vertexai): use correct MIME type for multimodal stream sample#5572
Merged
iennae merged 2 commits intoMay 20, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request corrects a MIME type for an image file and enhances the robustness of the streaming response loop by adding a nil check for the response and providing more descriptive error messages. A review comment suggests further improving the safety of the response handling by checking for a nil Content field within the first candidate to prevent potential panics.
f314a11 to
1be2938
Compare
Kef131
approved these changes
May 15, 2026
iennae
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses two issues in the
generativeaionvertexai_stream_multimodality_basicsample:Fixes Internal b/506216658
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
go test -v ./..(see Testing)gofmt(see Formatting)go vet(see Formatting)