Skip to content

Commit 22d7c22

Browse files
authored
Update PULL_REQUEST_TEMPLATE.md: Streamline and require manual system testing
1 parent 88f9884 commit 22d7c22

1 file changed

Lines changed: 13 additions & 8 deletions

File tree

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,23 @@
22

33
Fixes #<ISSUE-NUMBER>
44

5-
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
6-
75
## Checklist
86

9-
- [ ] I have followed [Sample Format Guide](https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md)
10-
- [ ] `pom.xml` parent set to latest `shared-configuration`
11-
- [ ] Appropriate changes to README are included in PR
12-
- [ ] These samples need a new **API enabled** in testing projects to pass (let us know which ones)
13-
- [ ] These samples need a new/updated **env vars** in testing projects set to pass (let us know which ones)
7+
### Testing
8+
9+
- [ ] **I have tested this change on a live environment and verified it works as intended.**
1410
- [ ] **Tests** pass: `mvn clean verify` **required**
1511
- [ ] **Lint** passes: `mvn -P lint checkstyle:check` **required**
1612
- [ ] **Static Analysis**: `mvn -P lint clean compile pmd:cpd-check spotbugs:check` **advisory only**
13+
14+
### Compliance & Style
15+
16+
- [ ] I have followed [Sample Format Guide](https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md)
17+
- [ ] `pom.xml` parent set to latest `shared-configuration`
18+
- [ ] Appropriate changes to README are included in PR
1719
- [ ] This sample adds a new sample directory, and I updated the [CODEOWNERS file](https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/.github/CODEOWNERS) with the codeowners for this sample
18-
- [ ] This sample adds a new **Product API**, and I updated the [Blunderbuss issue/PR auto-assigner](https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/.github/blunderbuss.yml) with the codeowners for this sample
20+
- [ ] This sample adds a new **Product API**, and I updated the [Blunderbuss issue/PR auto-assigner](https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/.github/blunderbuss.yml) with the codeowners for this sample
21+
22+
### Post-Approval Actions
23+
1924
- [ ] Please **merge** this PR for me once it is approved

0 commit comments

Comments
 (0)