Skip to content

Commit 2651a0a

Browse files
committed
Fix early return in multi-batch metric scraping and improve log hygiene
1 parent fe8f334 commit 2651a0a

1 file changed

Lines changed: 1 addition & 7 deletions

File tree

kubelet-to-gcm/monitor/poll.go

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,7 @@ func Once(src MetricsSource, gcm *v3.Service) {
5959
if empty, err := createCall.Do(); err != nil {
6060
log.Warningf("Failed to write time series data, empty: %v, err: %v", empty, err)
6161
observeFailedRequest(len(subReq.TimeSeries))
62-
jsonReq, err := subReq.MarshalJSON()
63-
if err != nil {
64-
log.Warningf("Failed to marshal time series as JSON")
65-
return
66-
}
67-
log.Warningf("JSON GCM: %s", string(jsonReq[:]))
68-
return
62+
continue
6963
}
7064
log.V(4).Infof("Successfully wrote TimeSeries data for %s to GCM v3 API.", src.Name())
7165
observeSuccessfullRequest(len(subReq.TimeSeries))

0 commit comments

Comments
 (0)