Merge pull request #1197 from laoj2/httpmux

laoj2 · web-flow · commit a2a3a79a5875 · 2026-05-20T14:40:25.000-04:00
Prevent http.DefaultServeMux exposure on CMSA
diff --git a/custom-metrics-stackdriver-adapter/adapter.go b/custom-metrics-stackdriver-adapter/adapter.go
@@ -291,8 +291,9 @@ func getDefinitionName(namer *openapinamer.DefinitionNamer, name string) (string
 }
 
 func runPrometheusMetricsServer(addr string) {
-	http.Handle("/metrics", promhttp.Handler())
-	err := http.ListenAndServe(addr, nil)
+	mux := http.NewServeMux()
+	mux.Handle("/metrics", promhttp.Handler())
+	err := http.ListenAndServe(addr, mux)
 	klog.Fatalf("Failed server: %s", err)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -291,8 +291,9 @@ func getDefinitionName(namer *openapinamer.DefinitionNamer, name string) (string`
`291`	`291`	`}`
`292`	`292`
`293`	`293`	`func runPrometheusMetricsServer(addr string) {`
`294`		`- http.Handle("/metrics", promhttp.Handler())`
`295`		`- err := http.ListenAndServe(addr, nil)`
	`294`	`+ mux := http.NewServeMux()`
	`295`	`+ mux.Handle("/metrics", promhttp.Handler())`
	`296`	`+ err := http.ListenAndServe(addr, mux)`
`296`	`297`	`klog.Fatalf("Failed server: %s", err)`
`297`	`298`	`}`
`298`	`299`