Fix quickstart Dockerfile warnings#2079
Open
Haihan-Jiang wants to merge 1 commit into
Open
Conversation
Author
|
This is ready for review from my side. The visible checks are green; could someone take a look when convenient? |
3c93c40 to
f2f8df1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the remaining quickstart Dockerfiles that still use Dockerfile forms covered by the warnings in #1781. The main
quickstarts/hello-appDockerfile was already fixed in #1829; this follows the same format for related quickstart samples.Changes:
ASfor multi-stage builder aliases.ENV key=valuefor quickstart environment variables.Validation:
git diff --checkFROM ... asor legacyENV key valueforms.docker buildforquickstarts/hello-app-cdn, but this machine is missing the Docker buildx component and the legacy builder stalled while pullinggolang:1.24.3; leaving this as draft until CI/maintainers can confirm.Related to #1781.
Tasks