Fix Ruby quickstart container startup#2080
Open
Haihan-Jiang wants to merge 1 commit into
Open
Conversation
0b853d9 to
908e1e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #901.
The Ruby quickstart was still missing the server gems required by current Sinatra. Building the image with the existing Gemfile and starting it in the
ruby:3.3-slimcontainer fails because Sinatra 4 cannot find a Rack handler.This PR adds the missing
rackupandpumaruntime dependencies, commits a lockfile for reproducible container builds, and runs the app throughbundle exec. The Dockerfile installs build tools only forbundle install, then removes them from the final image layer.Validation:
docker build -t kes-ruby-quickstart-test quickstarts/languages/rubydocker run -d --name kes-ruby-quickstart-test-run -p 18080:8080 -e TARGET=GKE kes-ruby-quickstart-testcurl -fsS http://localhost:18080/returnedHello GKE!git diff --checkTasks