Fix Model Armor sample path#2082
Open
Haihan-Jiang wants to merge 1 commit into
Open
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
2f8e129 to
6604c50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1713.
The Model Armor sample had a directory named
model-armor-guardrailwith a trailing space. Paths like that are easy to miss on Unix-like systems and can break checkout on platforms that reject trailing spaces in path components.This moves the sample manifest into
model-armor-guardrail/and also fixes the manifest indentation so the YAML parses cleanly.Validation:
ai-ml/gke-model-armor/model-armor-guardrail/model-armor-extension.yamlwith Ruby YAMLgit diff --cached --check