@ author and reviewers

Author: shuyama1

.ci/magician/cmd/interfaces.go

@@ -23,6 +23,7 @@ import (
 
 type GithubClient interface {
 	GetPullRequest(prNumber string) (github.PullRequest, error)
+	GetPullRequestAuthor(prNumber string) (string, error)
 	GetPullRequests(state, base, sort, direction string) ([]github.PullRequest, error)
 	GetPullRequestRequestedReviewers(prNumber string) ([]github.User, error)
 	GetPullRequestPreviousReviewers(prNumber string) ([]github.User, error)

.ci/magician/cmd/mock_github_test.go

@@ -38,6 +38,11 @@ func (m *mockGithub) GetPullRequest(prNumber string) (github.PullRequest, error)
 	return m.pullRequest, nil
 }
 
+func (m *mockGithub) GetPullRequestAuthor(prNumber string) (string, error) {
+	m.calledMethods["GetPullRequestAuthor"] = append(m.calledMethods["GetPullRequestAuthor"], []any{prNumber})
+	return m.pullRequest.User.Login, nil
+}
+
 func (m *mockGithub) GetPullRequests(state, base, sort, direction string) ([]github.PullRequest, error) {
 	m.calledMethods["GetPullRequests"] = append(m.calledMethods["GetPullRequests"], []any{state, base, sort, direction})
 	return []github.PullRequest{m.pullRequest}, nil

.ci/magician/cmd/test_terraform_vcr.go

@@ -263,6 +263,12 @@ func execTestTerraformVCR(prNumber, mmCommitSha, buildID, projectID, buildStep,
 	if err != nil {
 		return fmt.Errorf("error formatting post replay comment: %w", err)
 	}
+	if len(replayingResult.FailedTests) == 0 {
+		mentionStr := getMentions(prNumber, gh)
+		if mentionStr != "" {
+			comment = fmt.Sprintf("%s\n\n%s VCR tests complete for %s!", comment, mentionStr, mmCommitSha)
+		}
+	}
 	if err := appendVCRResultToDiffComment(prNumber, comment, gh, rnr); err != nil {
 		return fmt.Errorf("error appending comment: %w", err)
 	}
@@ -345,6 +351,10 @@ func execTestTerraformVCR(prNumber, mmCommitSha, buildID, projectID, buildStep,
 		if err != nil {
 			return fmt.Errorf("error formatting record replay comment: %w", err)
 		}
+		mentionStr := getMentions(prNumber, gh)
+		if mentionStr != "" {
+			recordReplayComment = fmt.Sprintf("%s\n\n%s VCR tests complete for %s!", recordReplayComment, mentionStr, mmCommitSha)
+		}
 		if err := appendVCRResultToDiffComment(prNumber, recordReplayComment, gh, rnr); err != nil {
 			return fmt.Errorf("error appending comment: %w", err)
 		}
@@ -501,6 +511,10 @@ func handlePanics(prNumber, buildID, buildStatusTargetURL, mmCommitSha string, r
 		comment := color("red", fmt.Sprintf("The provider crashed while running the VCR tests in %s mode\n", mode.Upper()))
 		comment += fmt.Sprintf(`Please fix it to complete your PR.
 View the [build log](https://storage.cloud.google.com/ci-vcr-logs/beta/refs/heads/auto-pr-%s/artifacts/%s/build-log/%s_test.log)`, prNumber, buildID, mode.Lower())
+		mentionStr := getMentions(prNumber, gh)
+		if mentionStr != "" {
+			comment = fmt.Sprintf("%s\n\n%s VCR tests complete for %s!", comment, mentionStr, mmCommitSha)
+		}
 		if err := appendVCRResultToDiffComment(prNumber, comment, gh, rnr); err != nil {
 			return true, fmt.Errorf("error appending comment: %v", err)
 		}
@@ -512,6 +526,35 @@ View the [build log](https://storage.cloud.google.com/ci-vcr-logs/beta/refs/head
 	return false, nil
 }
 
+func getMentions(prNumber string, gh GithubClient) string {
+	author := ""
+	reviewerMentions := ""
+	if authorName, err := gh.GetPullRequestAuthor(prNumber); err == nil {
+		author = "@" + authorName
+	}
+	if reviewers, err := gh.GetPullRequestRequestedReviewers(prNumber); err == nil {
+		var mentions []string
+		for _, r := range reviewers {
+			mentions = append(mentions, "@"+r.Login)
+		}
+		if len(mentions) > 0 {
+			reviewerMentions = strings.Join(mentions, ", ")
+		}
+	}
+
+	mentionStr := ""
+	if author != "" {
+		mentionStr += author
+	}
+	if reviewerMentions != "" {
+		if mentionStr != "" {
+			mentionStr += ", "
+		}
+		mentionStr += reviewerMentions
+	}
+	return mentionStr
+}
+
 // appendVCRResultToDiffComment appends content to the existing diff report comment
 // identified by the ID in /workspace/diff_comment_id.txt.
 // If the file is missing or the comment cannot be fetched, it falls back to posting a new comment.

.ci/magician/cmd/test_terraform_vcr_test.go

@@ -551,6 +551,13 @@ func TestRecordReplay(t *testing.T) {
 func TestAppendVCRResultToDiffComment_NotExists(t *testing.T) {
 	gh := &mockGithub{
 		calledMethods: make(map[string][][]any),
+		pullRequest: github.PullRequest{
+			User: github.User{Login: "author1"},
+		},
+		requestedReviewers: []github.User{
+			{Login: "reviewer1"},
+			{Login: "reviewer2"},
+		},
 		pullRequestComments: []github.PullRequestComment{
 			{
 				ID:   456,
@@ -571,6 +578,13 @@ func TestAppendVCRResultToDiffComment_NotExists(t *testing.T) {
 func TestAppendVCRResultToDiffComment_UseFileID(t *testing.T) {
 	gh := &mockGithub{
 		calledMethods: make(map[string][][]any),
+		pullRequest: github.PullRequest{
+			User: github.User{Login: "author1"},
+		},
+		requestedReviewers: []github.User{
+			{Login: "reviewer1"},
+			{Login: "reviewer2"},
+		},
 		pullRequestComments: []github.PullRequestComment{
 			{
 				ID:   456,

.ci/magician/github/get.go

@@ -70,6 +70,15 @@ func (c *Client) GetPullRequest(prNumber string) (PullRequest, error) {
 	return convertGHPullRequest(pr), nil
 }
 
+// GetPullRequestAuthor fetches the author of a pull request
+func (c *Client) GetPullRequestAuthor(prNumber string) (string, error) {
+	pr, err := c.GetPullRequest(prNumber)
+	if err != nil {
+		return "", err
+	}
+	return pr.User.Login, nil
+}
+
 // GetPullRequests fetches multiple pull requests
 func (c *Client) GetPullRequests(state, base, sort, direction string) ([]PullRequest, error) {
 	opts := &gh.PullRequestListOptions{