Update images for notebooks instance tests (#14719)

shuyama1 · web-flow · commit 7696e122cb52 · 2025-08-08T22:21:18.000Z
diff --git a/mmv1/products/notebooks/Instance.yaml b/mmv1/products/notebooks/Instance.yaml
@@ -80,19 +80,24 @@ examples:
       instance_name: 'notebooks-instance'
     ignore_read_extra:
       - 'desired_state'
+      - 'update_time'
     skip_test: https://github.com/hashicorp/terraform-provider-google/issues/17593#issuecomment-2888583933
   - name: 'notebook_instance_basic_container'
     primary_resource_id: 'instance'
     primary_resource_name: 'fmt.Sprintf("tf-test-notebooks-instance%s", context["random_suffix"])'
     region_override: 'us-west1-a'
     vars:
       instance_name: 'notebooks-instance'
+    ignore_read_extra:
+      - 'update_time'
   - name: 'notebook_instance_basic_gpu'
     primary_resource_id: 'instance'
     primary_resource_name: 'fmt.Sprintf("tf-test-notebooks-instance%s", context["random_suffix"])'
     region_override: 'us-west1-a'
     vars:
       instance_name: 'notebooks-instance'
+    ignore_read_extra:
+      - 'update_time'
   - name: 'notebook_instance_full'
     primary_resource_id: 'instance'
     primary_resource_name: 'fmt.Sprintf("tf-test-notebooks-instance%s", context["random_suffix"])'
@@ -104,6 +109,8 @@ examples:
       service_account: 'SERVICE_ACCT'
     test_vars_overrides:
       'key_name': 'acctest.BootstrapKMSKeyInLocation(t, "global").CryptoKey.Name'
+    ignore_read_extra:
+      - 'update_time'
 virtual_fields:
   - name: 'desired_state'
     description: |
diff --git a/mmv1/templates/terraform/examples/notebook_instance_basic.tf.tmpl b/mmv1/templates/terraform/examples/notebook_instance_basic.tf.tmpl
@@ -3,7 +3,7 @@ resource "google_notebooks_instance" "{{$.PrimaryResourceId}}" {
   location = "us-west1-a"
   machine_type = "e2-medium"
   vm_image {
-    project      = "deeplearning-platform-release"
-    image_family = "pytorch-latest-cu124"
+    project      = "cloud-notebooks-managed"
+    image_family = "workbench-instances"
   }
 }
diff --git a/mmv1/templates/terraform/examples/notebook_instance_basic_gpu.tf.tmpl b/mmv1/templates/terraform/examples/notebook_instance_basic_gpu.tf.tmpl
@@ -9,7 +9,7 @@ resource "google_notebooks_instance" "{{$.PrimaryResourceId}}" {
     core_count   = 1
   }
   vm_image {
-    project      = "deeplearning-platform-release"
-    image_family = "pytorch-latest-cu124"
+    project      = "cloud-notebooks-managed"
+    image_family = "workbench-instances"
   }
 }
diff --git a/mmv1/templates/terraform/examples/notebook_instance_basic_stopped.tf.tmpl b/mmv1/templates/terraform/examples/notebook_instance_basic_stopped.tf.tmpl
@@ -3,8 +3,8 @@ resource "google_notebooks_instance" "{{$.PrimaryResourceId}}" {
   location = "us-west1-a"
   machine_type = "e2-medium"
   vm_image {
-    project      = "deeplearning-platform-release"
-    image_family = "pytorch-latest-cu124"
+    project      = "cloud-notebooks-managed"
+    image_family = "workbench-instances"
   }
   desired_state = "STOPPED"
 }
diff --git a/mmv1/templates/terraform/examples/notebook_instance_full.tf.tmpl b/mmv1/templates/terraform/examples/notebook_instance_full.tf.tmpl
@@ -4,16 +4,16 @@ resource "google_notebooks_instance" "{{$.PrimaryResourceId}}" {
   machine_type = "e2-medium"
 
   vm_image {
-    project      = "deeplearning-platform-release"
-    image_family = "pytorch-latest-cu124"
+    project      = "cloud-notebooks-managed"
+    image_family = "workbench-instances"
   }
 
   instance_owners = [ "{{index $.TestEnvVars "service_account"}}"]
   service_account = "{{index $.TestEnvVars "service_account"}}"
 
   install_gpu_driver = true
   boot_disk_type = "PD_SSD"
-  boot_disk_size_gb = 110
+  boot_disk_size_gb = 150
 
   no_public_ip = true
   no_proxy_access = true
diff --git a/mmv1/third_party/terraform/services/notebooks/resource_notebooks_instance_gpu_test.go.tmpl b/mmv1/third_party/terraform/services/notebooks/resource_notebooks_instance_gpu_test.go.tmpl
@@ -44,8 +44,8 @@ resource "google_notebooks_instance" "test" {
     terraform  = "true"
   }
   vm_image {
-    project      = "deeplearning-platform-release"
-    image_family = "pytorch-latest-cu124"
+    project      = "cloud-notebooks-managed"
+    image_family = "workbench-instances"
   }
   install_gpu_driver = true
   accelerator_config {
diff --git a/mmv1/third_party/terraform/services/notebooks/resource_notebooks_instance_state_test.go.tmpl b/mmv1/third_party/terraform/services/notebooks/resource_notebooks_instance_state_test.go.tmpl
@@ -59,8 +59,8 @@ resource "google_notebooks_instance" "test" {
   location = "us-west1-a"
   machine_type = "e2-medium"
   vm_image {
-    project      = "deeplearning-platform-release"
-    image_family = "pytorch-latest-cu124"
+    project      = "cloud-notebooks-managed"
+    image_family = "workbench-instances"
   }
   desired_state = "ACTIVE"
 }
@@ -74,8 +74,8 @@ resource "google_notebooks_instance" "test" {
   location = "us-west1-a"
   machine_type = "e2-medium"
   vm_image {
-    project      = "deeplearning-platform-release"
-    image_family = "pytorch-latest-cu124"
+    project      = "cloud-notebooks-managed"
+    image_family = "workbench-instances"
   }
   desired_state = "STOPPED"
 }
diff --git a/mmv1/third_party/terraform/services/notebooks/resource_notebooks_instance_test.go b/mmv1/third_party/terraform/services/notebooks/resource_notebooks_instance_test.go
@@ -91,8 +91,8 @@ resource "google_notebooks_instance" "test" {
   }
 
   vm_image {
-    project      = "deeplearning-platform-release"
-    image_family = "pytorch-latest-cu124"
+    project      = "cloud-notebooks-managed"
+    image_family = "workbench-instances"
   }
 }
 `, name)
@@ -106,8 +106,8 @@ resource "google_notebooks_instance" "instance" {
   machine_type = "e2-medium"
 
   vm_image {
-    project      = "deeplearning-platform-release"
-    image_family = "pytorch-latest-cu124"
+    project      = "cloud-notebooks-managed"
+    image_family = "workbench-instances"
   }
 
   metadata = {
@@ -132,8 +132,8 @@ resource "google_notebooks_instance" "instance" {
   machine_type = "e2-medium"
 
   vm_image {
-    project      = "deeplearning-platform-release"
-    image_family = "pytorch-latest-cu124"
+    project      = "cloud-notebooks-managed"
+    image_family = "workbench-instances"
   }
 
   metadata = {

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ resource "google_notebooks_instance" "{{$.PrimaryResourceId}}" {`
`3`	`3`	`location = "us-west1-a"`
`4`	`4`	`machine_type = "e2-medium"`
`5`	`5`	`vm_image {`
`6`		`- project = "deeplearning-platform-release"`
`7`		`- image_family = "pytorch-latest-cu124"`
	`6`	`+ project = "cloud-notebooks-managed"`
	`7`	`+ image_family = "workbench-instances"`
`8`	`8`	`}`
`9`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ resource "google_notebooks_instance" "{{$.PrimaryResourceId}}" {`
`9`	`9`	`core_count = 1`
`10`	`10`	`}`
`11`	`11`	`vm_image {`
`12`		`- project = "deeplearning-platform-release"`
`13`		`- image_family = "pytorch-latest-cu124"`
	`12`	`+ project = "cloud-notebooks-managed"`
	`13`	`+ image_family = "workbench-instances"`
`14`	`14`	`}`
`15`	`15`	`}`
Original file line number	Diff line number	Diff line change
`@@ -3,8 +3,8 @@ resource "google_notebooks_instance" "{{$.PrimaryResourceId}}" {`
`3`	`3`	`location = "us-west1-a"`
`4`	`4`	`machine_type = "e2-medium"`
`5`	`5`	`vm_image {`
`6`		`- project = "deeplearning-platform-release"`
`7`		`- image_family = "pytorch-latest-cu124"`
	`6`	`+ project = "cloud-notebooks-managed"`
	`7`	`+ image_family = "workbench-instances"`
`8`	`8`	`}`
`9`	`9`	`desired_state = "STOPPED"`
`10`	`10`	`}`
Original file line number	Diff line number	Diff line change
`@@ -44,8 +44,8 @@ resource "google_notebooks_instance" "test" {`
`44`	`44`	`terraform = "true"`
`45`	`45`	`}`
`46`	`46`	`vm_image {`
`47`		`- project = "deeplearning-platform-release"`
`48`		`- image_family = "pytorch-latest-cu124"`
	`47`	`+ project = "cloud-notebooks-managed"`
	`48`	`+ image_family = "workbench-instances"`
`49`	`49`	`}`
`50`	`50`	`install_gpu_driver = true`
`51`	`51`	`accelerator_config {`
Original file line number	Diff line number	Diff line change
`@@ -59,8 +59,8 @@ resource "google_notebooks_instance" "test" {`
`59`	`59`	`location = "us-west1-a"`
`60`	`60`	`machine_type = "e2-medium"`
`61`	`61`	`vm_image {`
`62`		`- project = "deeplearning-platform-release"`
`63`		`- image_family = "pytorch-latest-cu124"`
	`62`	`+ project = "cloud-notebooks-managed"`
	`63`	`+ image_family = "workbench-instances"`
`64`	`64`	`}`
`65`	`65`	`desired_state = "ACTIVE"`
`66`	`66`	`}`
`@@ -74,8 +74,8 @@ resource "google_notebooks_instance" "test" {`
`74`	`74`	`location = "us-west1-a"`
`75`	`75`	`machine_type = "e2-medium"`
`76`	`76`	`vm_image {`
`77`		`- project = "deeplearning-platform-release"`
`78`		`- image_family = "pytorch-latest-cu124"`
	`77`	`+ project = "cloud-notebooks-managed"`
	`78`	`+ image_family = "workbench-instances"`
`79`	`79`	`}`
`80`	`80`	`desired_state = "STOPPED"`
`81`	`81`	`}`
Original file line number	Diff line number	Diff line change
`@@ -91,8 +91,8 @@ resource "google_notebooks_instance" "test" {`
`91`	`91`	`}`
`92`	`92`
`93`	`93`	`vm_image {`
`94`		`- project = "deeplearning-platform-release"`
`95`		`- image_family = "pytorch-latest-cu124"`
	`94`	`+ project = "cloud-notebooks-managed"`
	`95`	`+ image_family = "workbench-instances"`
`96`	`96`	`}`
`97`	`97`	`}`
`98`	`98`	`, name)
`@@ -106,8 +106,8 @@ resource "google_notebooks_instance" "instance" {`
`106`	`106`	`machine_type = "e2-medium"`
`107`	`107`
`108`	`108`	`vm_image {`
`109`		`- project = "deeplearning-platform-release"`
`110`		`- image_family = "pytorch-latest-cu124"`
	`109`	`+ project = "cloud-notebooks-managed"`
	`110`	`+ image_family = "workbench-instances"`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`metadata = {`
`@@ -132,8 +132,8 @@ resource "google_notebooks_instance" "instance" {`
`132`	`132`	`machine_type = "e2-medium"`
`133`	`133`
`134`	`134`	`vm_image {`
`135`		`- project = "deeplearning-platform-release"`
`136`		`- image_family = "pytorch-latest-cu124"`
	`135`	`+ project = "cloud-notebooks-managed"`
	`136`	`+ image_family = "workbench-instances"`
`137`	`137`	`}`
`138`	`138`
`139`	`139`	`metadata = {`