Add 'principal' field to ReservationAssignment.yaml

[vasilyl]

Added 'principal' field to ReservationAssignment.yaml with details on its usage and supported formats.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

bigquery: Added 'principal' field to ReservationAssignment resource

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 38 insertions(+))
google-beta provider: Diff ( 3 files changed, 38 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigquery_reservation_assignment (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigquery_reservation_assignment" "primary" {
  principal = # value needed
}

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 14
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• bigqueryreservation

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 38 insertions(+))
google-beta provider: Diff ( 3 files changed, 38 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigquery_reservation_assignment (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigquery_reservation_assignment" "primary" {
  principal = # value needed
}

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 14
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• bigqueryreservation

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 38 insertions(+))
google-beta provider: Diff ( 3 files changed, 38 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigquery_reservation_assignment (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigquery_reservation_assignment" "primary" {
  principal = # value needed
}

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 14
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• bigqueryreservation

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 38 insertions(+))
google-beta provider: Diff ( 3 files changed, 38 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigquery_reservation_assignment (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigquery_reservation_assignment" "primary" {
  principal = # value needed
}

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 14
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• bigqueryreservation

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 110 insertions(+))
google-beta provider: Diff ( 5 files changed, 110 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 110 insertions(+))
google-beta provider: Diff ( 5 files changed, 110 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccBigQueryReservationAssignment_basic

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• bigqueryreservation

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[modular-magician]

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccBigQueryReservationAssignment_basic

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• bigqueryreservation

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 110 insertions(+))
google-beta provider: Diff ( 5 files changed, 110 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Tests analytics

Total tests: 15
Passed tests: 13
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• bigqueryreservation

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBigQueryReservationAssignment_basic
• TestAccBigqueryReservationReservationAssignment_bigqueryReservationAssignmentFullExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccBigQueryReservationAssignment_basic [Error message] [Debug log]
TestAccBigqueryReservationReservationAssignment_bigqueryReservationAssignmentFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 111 insertions(+))
google-beta provider: Diff ( 5 files changed, 111 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Tests analytics

Total tests: 15
Passed tests: 13
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• bigqueryreservation

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBigQueryReservationAssignment_basic
• TestAccBigqueryReservationReservationAssignment_bigqueryReservationAssignmentFullExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccBigQueryReservationAssignment_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccBigqueryReservationReservationAssignment_bigqueryReservationAssignmentFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 112 insertions(+))
google-beta provider: Diff ( 5 files changed, 112 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 112 insertions(+))
google-beta provider: Diff ( 5 files changed, 112 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Tests analytics

Total tests: 15
Passed tests: 14
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• bigqueryreservation

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBigqueryReservationReservationAssignment_bigqueryReservationAssignmentFullExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccBigqueryReservationReservationAssignment_bigqueryReservationAssignmentFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 15
Passed tests: 14
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• bigqueryreservation

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBigqueryReservationReservationAssignment_bigqueryReservationAssignmentFullExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccBigqueryReservationReservationAssignment_bigqueryReservationAssignmentFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[github-actions]

@malhotrasagar2212 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[malhotrasagar2212]

Could you please link the API documentation showing that principal is available in the Ga v1 Reservation Assignment API? The REST docs currently do not list this field on Assignment, so before adding it to both google and google-beta we should confirm this is GA-supported. Thanks.
https://docs.cloud.google.com/bigquery/docs/reference/reservations/rest/v1/projects.locations.reservations.assignments

[vasilyl]

This is in Public preview yet. Should we update the REST docs (with the Preview badge) or wait for GA?

[malhotrasagar2212]

Since you confirmed this is currently in Public Preview , we should either wait until the field is in GA and documented in v1 REST docs, or add it in beta-only for now.

[github-actions]

@vasilyl, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5688aeb:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	4 files changed, 40 insertions(+)
google-beta provider	View Diff	4 files changed, 40 insertions(+)
terraform-google-conversion	View Diff	1 file changed, 10 insertions(+)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
15	15	0	0

Affected Service Packages

• bigqueryreservation

Learn how VCR tests work

---

Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the build log

@vasilyl, @wj-chen, @malhotrasagar2212 VCR tests complete for 5688aeb!

[github-actions]

@malhotrasagar2212 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@vasilyl, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[github-actions]

@vasilyl, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[github-actions]

@vasilyl, this PR is waiting for action from you. If no action is taken, this PR will be closed in 2 weekdays.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[fuzmish]

Hello,
Today, this feature has been officially released as preview, and the API reference explicitly expose it.

...
      "id": "Assignment",
      "description": "An assignment allows a project to submit jobs of a certain type using slots from the specified reservation.",
      "properties": {
        ...
        "principal": {
          "description": "Optional. Represents the principal for this assignment. If not empty, jobs run by this principal will utilize the associated reservation. Otherwise, jobs will fall back to using the reservation assigned to the project, folder, or organization (in that order). If no reservation is assigned at any of these levels, on-demand capacity will be used. The supported formats are: * `principal://goog/subject/USER_EMAIL_ADDRESS` for users, * `principal://iam.googleapis.com/projects/-/serviceAccounts/SA_EMAIL_ADDRESS` for service accounts, * `principal://iam.googleapis.com/projects/PROJECT_NUMBER/locations/global/workloadIdentityPools/POOL_ID/subject/SUBJECT_ID` for workload identity pool identities. * The special value `unknown_or_deleted_user` represents principals which cannot be read from the user info service, for example deleted users.",
          "type": "string"
        },

We are looking forward to this feature being made available in the Terraform provider.🤗

[github-actions]

@vasilyl, this PR is being closed due to inactivity.