Skip to content

Add exascaleDbStorageVault and storageManagementType fields to CloudV…#18145

Merged
roaks3 merged 1 commit into
GoogleCloudPlatform:mainfrom
virgulati2003:feature/oracledatabase-vmcluster-exascale
Jul 1, 2026
Merged

Add exascaleDbStorageVault and storageManagementType fields to CloudV…#18145
roaks3 merged 1 commit into
GoogleCloudPlatform:mainfrom
virgulati2003:feature/oracledatabase-vmcluster-exascale

Conversation

@virgulati2003

@virgulati2003 virgulati2003 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Description

This PR introduces support for configuring VM Clusters on top of dedicated Exascale DB Storage Vaults using the exascale_db_storage_vault parameter in google_oracle_database_cloud_vm_cluster.

It adds two new fields:

  1. exascale_db_storage_vault (ResourceRef, Optional, ForceNew): Associates the VM Cluster with a dedicated storage vault.
  2. storage_management_type (String, Output-only): Displays the storage system used (ASM or EXASCALE).

It also registers a new end-to-end integration test sample:
oracledatabase_cloud_vmcluster_exascale which provisions hardware, configures Exascale, carves out a storage vault, and deploys the Exascale VM cluster on top of it.

Fixes hashicorp/terraform-provider-google#28172

Release Note

oracledatabase: Added support for configuring Exascale-based VM clusters on top of dedicated storage vaults via the `exascale_db_storage_vault` parameter and `storage_management_type` to determine if VM Cluster is ASM or EXASCALE in `google_oracle_database_cloud_vm_cluster`

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 705946c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 261 insertions(+), 3 deletions(-)
google-beta provider View Diff 4 files changed, 261 insertions(+), 3 deletions(-)
terraform-google-conversion View Diff 1 file changed, 21 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 168 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
48 45 2 1
Affected Service Packages
  • oracledatabase

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccOracleDatabaseCloudVmCluster_oracledatabaseCloudVmclusterExascaleExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccOracleDatabaseCloudVmCluster_oracledatabaseCloudVmclusterExascaleExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@virgulati2003, @roaks3 VCR tests complete for 705946c!

@virgulati2003 virgulati2003 force-pushed the feature/oracledatabase-vmcluster-exascale branch from 705946c to a4790ba Compare July 1, 2026 11:04
@modular-magician

modular-magician commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a4790ba:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 265 insertions(+), 3 deletions(-)
google-beta provider View Diff 4 files changed, 265 insertions(+), 3 deletions(-)
terraform-google-conversion View Diff 1 file changed, 21 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 170 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
48 45 2 1
Affected Service Packages
  • oracledatabase

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccOracleDatabaseCloudVmCluster_oracledatabaseCloudVmclusterExascaleExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccOracleDatabaseCloudVmCluster_oracledatabaseCloudVmclusterExascaleExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@virgulati2003, @roaks3 VCR tests complete for a4790ba!

@virgulati2003 virgulati2003 force-pushed the feature/oracledatabase-vmcluster-exascale branch from a4790ba to 0425d30 Compare July 1, 2026 13:38
@modular-magician

modular-magician commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 0425d30:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 293 insertions(+), 3 deletions(-)
google-beta provider View Diff 4 files changed, 293 insertions(+), 3 deletions(-)
terraform-google-conversion View Diff 1 file changed, 21 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 184 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
48 45 2 1
Affected Service Packages
  • oracledatabase

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccOracleDatabaseCloudVmCluster_oracledatabaseCloudVmclusterExascaleExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccOracleDatabaseCloudVmCluster_oracledatabaseCloudVmclusterExascaleExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@virgulati2003, @roaks3 VCR tests complete for 0425d30!

@virgulati2003 virgulati2003 force-pushed the feature/oracledatabase-vmcluster-exascale branch from 0425d30 to af66b79 Compare July 1, 2026 14:45
@modular-magician

modular-magician commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit af66b79:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 293 insertions(+), 3 deletions(-)
google-beta provider View Diff 4 files changed, 293 insertions(+), 3 deletions(-)
terraform-google-conversion View Diff 1 file changed, 21 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 184 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
48 45 2 1
Affected Service Packages
  • oracledatabase

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccOracleDatabaseCloudVmCluster_oracledatabaseCloudVmclusterExascaleExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccOracleDatabaseCloudVmCluster_oracledatabaseCloudVmclusterExascaleExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@virgulati2003, @roaks3 VCR tests complete for af66b79!

@roaks3 roaks3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but one comment on the type

Comment thread mmv1/products/oracledatabase/CloudVmCluster.yaml Outdated
@virgulati2003 virgulati2003 force-pushed the feature/oracledatabase-vmcluster-exascale branch from af66b79 to b426c79 Compare July 1, 2026 20:03
@github-actions github-actions Bot requested a review from roaks3 July 1, 2026 20:03
@modular-magician

modular-magician commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b426c79:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 287 insertions(+)
google-beta provider View Diff 4 files changed, 287 insertions(+)
terraform-google-conversion View Diff 1 file changed, 21 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 184 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
48 46 2 0
Affected Service Packages
  • oracledatabase

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@virgulati2003, @roaks3 VCR tests complete for b426c79!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Exascale VM Clusters in google_oracle_database_cloud_vm_cluster

3 participants