Skip to content

[Compute] Add accelerator_topology_mode and slice_count to google_compute_resource_policy#17258

Open
modular-apprentice wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
modular-apprentice:auto-pr-1776928457926208610
Open

[Compute] Add accelerator_topology_mode and slice_count to google_compute_resource_policy#17258
modular-apprentice wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
modular-apprentice:auto-pr-1776928457926208610

Conversation

@modular-apprentice
Copy link
Copy Markdown
Contributor

This PR adds support for accelerator_topology_mode and slice_count within the group_placement_policy block of the google_compute_resource_policy resource. It also includes an acceptance test to verify the functionality of these new fields.

compute: added `group_placement_policy.accelerator_topology_mode` and `group_placement_policy.slice_count` fields to `google_compute_resource_policy` resource

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 140 insertions(+))
google-beta provider: Diff ( 4 files changed, 140 insertions(+))
terraform-google-conversion: Diff ( 5 files changed, 84 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 111 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1419
Passed tests: 1327
Skipped tests: 91
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeResourcePolicy_resourcePolicyPlacementPolicyMultisliceExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeResourcePolicy_resourcePolicyPlacementPolicyMultisliceExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants