Skip to content

feat: enable data sources for HTTP(S) Target Proxies#17265

Open
muxanasov wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
muxanasov:fix-302797446-target-proxies-ds
Open

feat: enable data sources for HTTP(S) Target Proxies#17265
muxanasov wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
muxanasov:fix-302797446-target-proxies-ds

Conversation

@muxanasov
Copy link
Copy Markdown
Contributor

@muxanasov muxanasov commented Apr 23, 2026

Enables data sources for:

  • google_compute_target_http_proxy
  • google_compute_target_https_proxy
  • google_compute_region_target_http_proxy
  • google_compute_region_target_https_proxy

Fixes b/302797446
Fixes hashicorp/terraform-provider-google#11437

compute: added data sources for `google_compute_target_http_proxy`, `google_compute_target_https_proxy`, `google_compute_region_target_http_proxy`, and `google_compute_region_target_https_proxy`

@muxanasov
feat: enable data sources for HTTP(S) Target Proxies
ae560ab 
Enables data sources for:
- google_compute_target_http_proxy
- google_compute_target_https_proxy
- google_compute_region_target_http_proxy
- google_compute_region_target_https_proxy

Fixes b/302797446
Fixes hashicorp/terraform-provider-google#11437
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 23, 2026
@github-actions github-actions Bot requested a review from roaks3 April 23, 2026 15:20
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

roaks3
roaks3 approved these changes Apr 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending tests

@modular-magician modular-magician added service/compute-l7-load-balancer and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 27, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Apr 27, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 991 insertions(+))
google-beta provider: Diff ( 8 files changed, 991 insertions(+))

Missing doc report (experimental)

The following data sources are missing documents:

  • google_compute_region_target_http_proxy, expect file /website/docs/d/compute_region_target_http_proxy.html.markdown to exist.
  • google_compute_region_target_https_proxy, expect file /website/docs/d/compute_region_target_https_proxy.html.markdown to exist.
  • google_compute_target_http_proxy, expect file /website/docs/d/compute_target_http_proxy.html.markdown to exist.
  • google_compute_target_https_proxy, expect file /website/docs/d/compute_target_https_proxy.html.markdown to exist.

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Apr 27, 2026

Tests analytics

Total tests: 1425
Passed tests: 1329
Skipped tests: 91
Affected tests: 5

Click here to see the affected service packages
  • compute

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
  • TestAccDataSourceComputeRegionTargetHttpProxy_basic
  • TestAccDataSourceComputeRegionTargetHttpsProxy_basic
  • TestAccDataSourceComputeTargetHttpProxy_basic
  • TestAccDataSourceComputeTargetHttpsProxy_basic

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Apr 27, 2026

🟢 Tests passed during RECORDING mode:
TestAccComputeRouterPeer_UpdateMd5AuthenticationKey [Debug log]
TestAccDataSourceComputeRegionTargetHttpProxy_basic [Debug log]
TestAccDataSourceComputeRegionTargetHttpsProxy_basic [Debug log]
TestAccDataSourceComputeTargetHttpProxy_basic [Debug log]
TestAccDataSourceComputeTargetHttpsProxy_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccComputeRouterPeer_UpdateMd5AuthenticationKey [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🟢 All tests passed!

View the build log or the debug log for each test

roaks3
roaks3 requested changes Apr 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yea, I forgot that we haven't gotten around to generating the documentation quite yet. You could possibly try to wait, but I'm not sure when that will get implemented. The better option is probably to just add the docs manually (for example: https://github.com/GoogleCloudPlatform/magic-modules/pull/16088/changes#diff-bf9554e7a69efaceb17c6dd9e5076d5add7fb847dfd867cab4de8f2be2292012)

Apologies for this feature being a bit incomplete for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roaks3 roaks3 roaks3 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

service/compute-l7-load-balancer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Google provider does not implement data sources for target HTTP proxies

3 participants

@muxanasov @modular-magician @roaks3