Tavasyag/compute instance list

mmv1/third_party/terraform/fwprovider/framework_provider_mmv1_resources.go

@@ -3,6 +3,7 @@ package fwprovider
 import (
 	"github.com/hashicorp/terraform-plugin-framework/list"
 
+	"github.com/hashicorp/terraform-provider-google/google/services/compute"
 	"github.com/hashicorp/terraform-provider-google/google/services/resourcemanager"
 )
 
@@ -15,6 +16,7 @@ func listResourceFunc(lr list.ListResource) func() list.ListResource {
 var generatedListResources = []func() list.ListResource{}
 
 var handwrittenListResources = []func() list.ListResource{
+	listResourceFunc(compute.NewGoogleComputeInstanceListResource()),
 	listResourceFunc(resourcemanager.NewGoogleServiceAccountListResource()),
 	listResourceFunc(resourcemanager.NewGoogleProjectServiceListResource()),
 }

mmv1/third_party/terraform/services/compute/list_google_compute_instance.go.tmpl

@@ -0,0 +1,143 @@
+// Copyright (c) IBM Corp. 2014, 2026
+// SPDX-License-Identifier: MPL-2.0
+
+package compute
+
+import (
+	"context"
+	"errors"
+	"fmt"
+
+	"github.com/hashicorp/terraform-plugin-framework/diag"
+	"github.com/hashicorp/terraform-plugin-framework/list"
+	"github.com/hashicorp/terraform-plugin-framework/types"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
+{{ if eq $.TargetVersionName `ga` }}
+	"google.golang.org/api/compute/v1"
+{{- else }}
+	compute "google.golang.org/api/compute/v0.beta"
+{{- end }}
+
+	"github.com/hashicorp/terraform-provider-google/google/tpgresource"
+	transport_tpg "github.com/hashicorp/terraform-provider-google/google/transport"
+)
+
+type GoogleComputeInstanceListResource struct {
+	tpgresource.ListResourceMetadata
+}
+
+// GoogleComputeInstanceListModel matches [ListResourceMetadata.ListConfigFields] (tfsdk names and types).
+type GoogleComputeInstanceListModel struct {
+	Project types.String `tfsdk:"project"`
+	Zone    types.String `tfsdk:"zone"`
+}
+
+func NewGoogleComputeInstanceListResource() list.ListResource {
+	listR := &GoogleComputeInstanceListResource{}
+	listR.TypeName = "google_compute_instance"
+	listR.SDKv2Resource = ResourceComputeInstance()
+	listR.ListConfigFields = []tpgresource.ListConfigField{
+		{Name: "project", Kind: tpgresource.ListConfigKindString, Optional: true},
+		{Name: "zone", Kind: tpgresource.ListConfigKindString, Optional: true},
+	}
+	return listR
+}
+
+func (listR *GoogleComputeInstanceListResource) List(ctx context.Context, listReq list.ListRequest, stream *list.ListResultsStream) {
+	var data GoogleComputeInstanceListModel
+	diags := listReq.Config.Get(ctx, &data)
+	if diags.HasError() {
+		stream.Results = list.ListResultsStreamDiagnostics(diags)
+		return
+	}
+	if listR.Client == nil {
+		diags = append(diags, diag.NewErrorDiagnostic(
+			"Provider not configured",
+			"The Google provider client is not available; ensure the provider is configured (e.g. credentials and default project).",
+		))
+		stream.Results = list.ListResultsStreamDiagnostics(diags)
+		return
+	}
+	project := tpgresource.GetResourceNameFromSelfLink(listR.GetProject(data.Project))
+	zone := listR.GetZone(data.Zone)
+
+	stream.Results = func(push func(list.ListResult) bool) {
+		err := ListComputeInstances(listR.Client, project, zone, func(rd *schema.ResourceData) error {
+			result := listReq.NewListResult(ctx)
+
+			if err := listR.SetResult(ctx, listReq.IncludeResource, &result, rd, "name"); err != nil {
+				return err
+			}
+
+			if !push(result) {
+				return errors.New("stream closed")
+			}
+			return nil
+		})
+		if err != nil {
+			diags.AddError("API Error", err.Error())
+			result := listReq.NewListResult(ctx)
+			result.Diagnostics = diags
+			push(result)
+		}
+	}
+}
+
+func flattenComputeInstanceListItem(res map[string]interface{}, d *schema.ResourceData, config *transport_tpg.Config) error {
+	var instance compute.Instance
+	if err := tpgresource.Convert(res, &instance); err != nil {
+		return fmt.Errorf("error converting compute instance list response: %w", err)
+	}
+	if instance.Name == "" {
+		return fmt.Errorf("missing name in compute instance list response")
+	}
+
+	project := d.Get("project").(string)
+	zone := tpgresource.GetResourceNameFromSelfLink(instance.Zone)
+
+	d.SetId(fmt.Sprintf("projects/%s/zones/%s/instances/%s", project, zone, instance.Name))
+	return populateComputeInstanceResourceData(d, &instance, project, zone, config)
+}
+
+func ListComputeInstances(config *transport_tpg.Config, project, zone string, callback func(rd *schema.ResourceData) error) error {
+	if config == nil {
+		return fmt.Errorf("provider client is not configured")
+	}
+	d := ResourceComputeInstance().Data(&terraform.InstanceState{})
+	if zone != "" {
+		if err := d.Set("zone", zone); err != nil {
+			return fmt.Errorf("error setting zone on temporary resource data: %w", err)
+		}
+	}
+	if project != "" {
+		if err := d.Set("project", project); err != nil {
+			return fmt.Errorf("error setting project on temporary resource data: %w", err)
+		}
+	}
+	url, err := tpgresource.ReplaceVars(d, config, "{{"{{"}}ComputeBasePath{{"}}"}}projects/{{"{{"}}project{{"}}"}}/zones/{{"{{"}}zone{{"}}"}}/instances")
+	if err != nil {
+		return err
+	}
+
+	billingProject := ""
+	if bp, err := tpgresource.GetBillingProject(d, config); err == nil {
+		billingProject = bp
+	}
+
+	userAgent, err := tpgresource.GenerateUserAgentString(d, config.UserAgent)
+	if err != nil {
+		return err
+	}
+
+	return transport_tpg.ListPages(transport_tpg.ListPagesOptions{
+		Config:         config,
+		TempData:       d,
+		ListURL:        url,
+		BillingProject: billingProject,
+		UserAgent:      userAgent,
+		ItemName:       "items",
+		Flattener:      flattenComputeInstanceListItem,
+		Callback:       callback,
+	})
+}

mmv1/third_party/terraform/services/compute/list_google_compute_instance_test.go

@@ -0,0 +1,91 @@
+// Copyright (c) IBM Corp. 2014, 2026
+// SPDX-License-Identifier: MPL-2.0
+
+package compute_test
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
+	"github.com/hashicorp/terraform-plugin-testing/knownvalue"
+	"github.com/hashicorp/terraform-plugin-testing/querycheck"
+	"github.com/hashicorp/terraform-plugin-testing/tfversion"
+
+	"github.com/hashicorp/terraform-provider-google/google/acctest"
+	"github.com/hashicorp/terraform-provider-google/google/envvar"
+)
+
+func TestAccComputeInstanceListResource_queryIdentity(t *testing.T) {
+	t.Parallel()
+
+	project := envvar.GetTestProjectFromEnv()
+	zone := envvar.GetTestZoneFromEnv()
+	name := fmt.Sprintf("tf-test-instance-%s", acctest.RandString(t, 10))
+
+	acctest.VcrTest(t, resource.TestCase{
+		TerraformVersionChecks: []tfversion.TerraformVersionCheck{
+			tfversion.SkipBelow(tfversion.Version1_14_0),
+		},
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccComputeInstanceListBasic(zone, name),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("google_compute_instance.test", "zone", zone),
+					resource.TestCheckResourceAttr("google_compute_instance.test", "project", project),
+					resource.TestCheckResourceAttr("google_compute_instance.test", "name", name),
+				),
+			},
+			{
+				Query:  true,
+				Config: testAccComputeInstanceListQuery(project, zone),
+				QueryResultChecks: []querycheck.QueryResultCheck{
+					querycheck.ExpectIdentity("google_compute_instance.all_in_zone", map[string]knownvalue.Check{
+						"zone":    knownvalue.StringExact(zone),
+						"project": knownvalue.StringExact(project),
+						"name":    knownvalue.StringExact(name),
+					}),
+					querycheck.ExpectLengthAtLeast("google_compute_instance.all_in_zone", 1),
+				},
+			},
+		},
+	})
+}
+
+func testAccComputeInstanceListBasic(zone, name string) string {
+	return fmt.Sprintf(`
+resource "google_compute_instance" "test" {
+  name         = %q
+  zone         = %q
+  machine_type = "e2-micro"
+
+  boot_disk {
+    initialize_params {
+      image = "debian-cloud/debian-11"
+    }
+  }
+
+  network_interface {
+    network = "default"
+
+    access_config {
+    }
+  }
+}
+`, name, zone)
+}
+
+func testAccComputeInstanceListQuery(project, zone string) string {
+	return fmt.Sprintf(`
+list "google_compute_instance" "all_in_zone" {
+  provider = google
+
+  config {
+    project = %q
+    zone    = %q
+  }
+}
+`, project, zone)
+}