Skip to content

Add QaScorecard Revision and Question resources#17279

Open
slevenick wants to merge 7 commits intoGoogleCloudPlatform:mainfrom
slevenick:qascorecard
Open

Add QaScorecard Revision and Question resources#17279
slevenick wants to merge 7 commits intoGoogleCloudPlatform:mainfrom
slevenick:qascorecard

Conversation

@slevenick
Copy link
Copy Markdown
Contributor

@slevenick slevenick commented Apr 23, 2026

Fixes: hashicorp/terraform-provider-google#26658

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_contact_center_insights_qa_scorecard`
`google_contact_center_insights_qa_question`
`google_contact_center_insights_qa_scorecard_revision`

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 3957 insertions(+))
google-beta provider: Diff ( 13 files changed, 3957 insertions(+))
terraform-google-conversion: Diff ( 3 files changed, 707 insertions(+))
Open in Cloud Shell: Diff ( 12 files changed, 351 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_contact_center_insights_qa_question (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_contact_center_insights_qa_question" "primary" {
  abbreviation = # value needed
  answer_choices {
    bool_value = # value needed
    key        = # value needed
    na_value   = # value needed
    num_value  = # value needed
  }
  answer_instructions = # value needed
  order               = # value needed
  predefined_question_config {
    type = # value needed
  }
  qa_question_data_options {
    conversation_data_options {
      include_dialogflow_interaction_data = # value needed
    }
  }
  tags = # value needed
  tuning_metadata {
    dataset_validation_warnings = # value needed
    total_valid_label_count     = # value needed
    tuning_error                = # value needed
  }
}

Resource: google_contact_center_insights_qa_scorecard_revision (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_contact_center_insights_qa_scorecard_revision" "primary" {
  qa_scorecard_revision_id = # value needed
  snapshot {
    description  = # value needed
    display_name = # value needed
    is_default   = # value needed
    source       = # value needed
  }
}

Multiple resources added

This PR adds multiple new resources: google_contact_center_insights_qa_question, google_contact_center_insights_qa_scorecard, google_contact_center_insights_qa_scorecard_revision. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 16
Passed tests: 12
Skipped tests: 1
Affected tests: 3

Click here to see the affected service packages
  • contactcenterinsights

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContactCenterInsightsQaQuestion_contactCenterInsightsQaQuestionBasicExample
  • TestAccContactCenterInsightsQaScorecardRevision_contactCenterInsightsQaScorecardRevisionBasicExample
  • TestAccContactCenterInsightsQaScorecard_contactCenterInsightsQaScorecardBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContactCenterInsightsQaQuestion_contactCenterInsightsQaQuestionBasicExample [Debug log]
TestAccContactCenterInsightsQaScorecardRevision_contactCenterInsightsQaScorecardRevisionBasicExample [Debug log]
TestAccContactCenterInsightsQaScorecard_contactCenterInsightsQaScorecardBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 4237 insertions(+))
google-beta provider: Diff ( 16 files changed, 4237 insertions(+))
terraform-google-conversion: Diff ( 3 files changed, 707 insertions(+))
Open in Cloud Shell: Diff ( 12 files changed, 351 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_contact_center_insights_qa_question (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_contact_center_insights_qa_question" "primary" {
  abbreviation = # value needed
  answer_choices {
    bool_value = # value needed
    key        = # value needed
    na_value   = # value needed
    num_value  = # value needed
  }
  answer_instructions = # value needed
  order               = # value needed
  predefined_question_config {
    type = # value needed
  }
  qa_question_data_options {
    conversation_data_options {
      include_dialogflow_interaction_data = # value needed
    }
  }
  tags = # value needed
  tuning_metadata {
    dataset_validation_warnings = # value needed
    total_valid_label_count     = # value needed
    tuning_error                = # value needed
  }
}

Resource: google_contact_center_insights_qa_scorecard_revision (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_contact_center_insights_qa_scorecard_revision" "primary" {
  qa_scorecard_revision_id = # value needed
  snapshot {
    description  = # value needed
    display_name = # value needed
    is_default   = # value needed
    source       = # value needed
  }
}

Multiple resources added

This PR adds multiple new resources: google_contact_center_insights_qa_question, google_contact_center_insights_qa_scorecard, google_contact_center_insights_qa_scorecard_revision. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

@modular-magician
Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccContactCenterInsightsQaQuestion_contactCenterInsightsQaQuestionBasicExample
  • TestAccContactCenterInsightsQaQuestion_update
  • TestAccContactCenterInsightsQaScorecardRevision_contactCenterInsightsQaScorecardRevisionBasicExample
  • TestAccContactCenterInsightsQaScorecardRevision_qaScorecardRevisionOptional
  • TestAccContactCenterInsightsQaScorecard_contactCenterInsightsQaScorecardBasicExample
  • TestAccContactCenterInsightsQaScorecard_update

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • contactcenterinsights

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 4236 insertions(+))
google-beta provider: Diff ( 16 files changed, 4236 insertions(+))
terraform-google-conversion: Diff ( 3 files changed, 707 insertions(+))
Open in Cloud Shell: Diff ( 12 files changed, 351 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_contact_center_insights_qa_question (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_contact_center_insights_qa_question" "primary" {
  abbreviation = # value needed
  answer_choices {
    bool_value = # value needed
    key        = # value needed
    na_value   = # value needed
    num_value  = # value needed
  }
  answer_instructions = # value needed
  order               = # value needed
  predefined_question_config {
    type = # value needed
  }
  qa_question_data_options {
    conversation_data_options {
      include_dialogflow_interaction_data = # value needed
    }
  }
  tags = # value needed
  tuning_metadata {
    dataset_validation_warnings = # value needed
    total_valid_label_count     = # value needed
    tuning_error                = # value needed
  }
}

Resource: google_contact_center_insights_qa_scorecard_revision (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_contact_center_insights_qa_scorecard_revision" "primary" {
  qa_scorecard_revision_id = # value needed
  snapshot {
    description  = # value needed
    display_name = # value needed
    is_default   = # value needed
    source       = # value needed
  }
}

Multiple resources added

This PR adds multiple new resources: google_contact_center_insights_qa_question, google_contact_center_insights_qa_scorecard, google_contact_center_insights_qa_scorecard_revision. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 19
Passed tests: 15
Skipped tests: 1
Affected tests: 3

Click here to see the affected service packages
  • contactcenterinsights

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContactCenterInsightsQaQuestion_update
  • TestAccContactCenterInsightsQaScorecardRevision_qaScorecardRevisionOptional
  • TestAccContactCenterInsightsQaScorecard_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContactCenterInsightsQaQuestion_update [Debug log]
TestAccContactCenterInsightsQaScorecardRevision_qaScorecardRevisionOptional [Debug log]
TestAccContactCenterInsightsQaScorecard_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 4235 insertions(+))
google-beta provider: Diff ( 16 files changed, 4235 insertions(+))
terraform-google-conversion: Diff ( 3 files changed, 707 insertions(+))
Open in Cloud Shell: Diff ( 12 files changed, 351 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_contact_center_insights_qa_question (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_contact_center_insights_qa_question" "primary" {
  abbreviation = # value needed
  answer_choices {
    bool_value = # value needed
    key        = # value needed
    na_value   = # value needed
    num_value  = # value needed
  }
  answer_instructions = # value needed
  order               = # value needed
  predefined_question_config {
    type = # value needed
  }
  qa_question_data_options {
    conversation_data_options {
      include_dialogflow_interaction_data = # value needed
    }
  }
  tags = # value needed
  tuning_metadata {
    dataset_validation_warnings = # value needed
    total_valid_label_count     = # value needed
    tuning_error                = # value needed
  }
}

Resource: google_contact_center_insights_qa_scorecard_revision (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_contact_center_insights_qa_scorecard_revision" "primary" {
  qa_scorecard_revision_id = # value needed
  snapshot {
    description  = # value needed
    display_name = # value needed
    is_default   = # value needed
    source       = # value needed
  }
}

Multiple resources added

This PR adds multiple new resources: google_contact_center_insights_qa_question, google_contact_center_insights_qa_scorecard, google_contact_center_insights_qa_scorecard_revision. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 19
Passed tests: 18
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • contactcenterinsights

🟢 All tests passed!

View the build log

@slevenick slevenick requested review from a team and SirGitsalot and removed request for a team April 24, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add google_contact_center_insights_qa_scorecard* resources

2 participants