resourcemanager: add google_project_service list resource#17297
resourcemanager: add google_project_service list resource#17297BBBmau wants to merge 6 commits intoGoogleCloudPlatform:mainfrom
resourcemanager: add google_project_service list resource#17297Conversation
90bbd8e to
860668d
Compare
Tests analyticsTotal tests: 174 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Tests analyticsTotal tests: 6351 Click here to see the affected service packages
Action takenFound 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
|
we should be good to get this merged back in after #17337 was merged |
|
@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label |
TeamCity Build with multiple runs made
change from this PR to the initial PR that was reverted was bootstrapping a project for starting a service followed by the query run
i think what was happening was due to the project being used containing upto 144 services it required multiple GET requests with
newPageTokensbeing used. There might've been a case where the service itself wasn't propagated fully so when newPages were being obtained they still didnt' have the existing service set.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.