Moved NewComputeClient -> compute.NewClient

[melinath]

Isolating service-specific code to service packages. I had to move GetInterconnectAttachmentLink to avoid a circular dependency.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

[melinath]

gofmt issue is unrelated

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 96 files changed, 371 insertions(+), 293 deletions(-))
google-beta provider: Diff ( 100 files changed, 383 insertions(+), 303 deletions(-))
terraform-google-conversion: Diff ( 9 files changed, 51 insertions(+), 34 deletions(-))

[modular-magician]

Tests analytics

Total tests: 6350
Passed tests: 5685
Skipped tests: 652
Affected tests: 13

Click here to see the affected service packages

All service packages are affected

Action taken

Found 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
• TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
• TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
• TestAccCloudRunService_cloudRunServiceGpuExample
• TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
• TestAccContainerCluster_updateVersion
• TestAccContainerCluster_withAutopilotResourceManagerTags
• TestAccContainerNodePool_withHostMaintenancePolicy
• TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
• TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
• TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
• TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
• TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRouterPeer_UpdateMd5AuthenticationKey [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceGpuExample [Error message] [Debug log]
TestAccContainerCluster_updateVersion [Error message] [Debug log]
TestAccContainerCluster_withAutopilotResourceManagerTags [Error message] [Debug log]
TestAccContainerNodePool_withHostMaintenancePolicy [Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]
TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionTagsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test