GA on failed healthcheck#17998
Conversation
…A, including implementation, documentation and tests
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit fbfe50b: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @RooBarsic, @roaks3, @chayankumar999 VCR tests complete for fbfe50b! |
| - api_field: 'id' | ||
| field: 'instance_group_manager_id' | ||
| - api_field: 'instanceLifecyclePolicy.defaultActionOnFailure' | ||
| {{- if ne $.TargetVersionName "ga" }} |
There was a problem hiding this comment.
Does this change required for handwritten resource? Shouldn't it be cleaned up after clearing the tag from the handwritten resource?
There was a problem hiding this comment.
Looking at the history of this files, seems like it is required now a days. LGTM.
|
@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
b401ad8
This promotes Compute (R)IGM.InstanceLifecyclePolicy.OnFailedHealthCheck functionalities in V1.
All the IGM and RIGM tests have been ran and pass.
fixes hashicorp/terraform-provider-google#27886
If this PR is for Terraform, I acknowledge that I have:
Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.