Add shutdown_grace_period_seconds and shutdown_grace_period_critical_pods_seconds fields to GKE cluster kubelet_config by chenggu88 · Pull Request #17999 · GoogleCloudPlatform/magic-modules

chenggu88 · 2026-06-18T04:00:59Z

This PR adds two new fields to customize node-level shutdown grace periods on Spot/Preemptible VMs within GKE node pools:

shutdown_grace_period_seconds
shutdown_grace_period_critical_pods_seconds

An acceptance test case TestAccContainerCluster_withKubeletConfigShutdownGracePeriod has been added and successfully verified against a GKE Standard cluster using Spot VMs.

Release Note Template for Downstream PRs (will be copied)

container: added new fields `shutdown_grace_period_seconds` and `shutdown_grace_period_critical_pods_seconds` to `node_kubelet_config` block.

github-actions · 2026-06-18T04:01:29Z

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2026-06-18T04:12:06Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 0381b68:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	2 files changed, 113 insertions(+), 22 deletions(-)
`google-beta` provider	View Diff	2 files changed, 113 insertions(+), 22 deletions(-)
`terraform-google-conversion`	View Diff	2 files changed, 60 insertions(+), 21 deletions(-)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (577 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_pool {
    node_config {
      kubelet_config {
        shutdown_grace_period_critical_pods_seconds = # value needed
        shutdown_grace_period_seconds               = # value needed
      }
    }
  }
  node_pool_auto_config {
    node_kubelet_config {
      shutdown_grace_period_critical_pods_seconds = # value needed
      shutdown_grace_period_seconds               = # value needed
    }
  }
}

Resource: google_container_node_pool (132 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_node_pool" "primary" {
  node_config {
    kubelet_config {
      shutdown_grace_period_critical_pods_seconds = # value needed
      shutdown_grace_period_seconds               = # value needed
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

google_container_cluster
- Expected Document Path: /website/docs/r/container_cluster.html.markdown
- Fields: [node_config.kubelet_config.shutdown_grace_period_critical_pods_seconds node_config.kubelet_config.shutdown_grace_period_seconds node_pool.node_config.kubelet_config.shutdown_grace_period_critical_pods_seconds node_pool.node_config.kubelet_config.shutdown_grace_period_seconds node_pool_auto_config.node_kubelet_config.shutdown_grace_period_critical_pods_seconds node_pool_auto_config.node_kubelet_config.shutdown_grace_period_seconds]
google_container_node_pool
- Expected Document Path: /website/docs/r/container_node_pool.html.markdown
- Fields: [node_config.kubelet_config.shutdown_grace_period_critical_pods_seconds node_config.kubelet_config.shutdown_grace_period_seconds]

Test report

Analytics

Total Tests	Passed	Skipped	Affected
305	279	14	12

Affected Service Packages

container

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

TestAccContainerCluster_regionalWithNodePool
TestAccContainerCluster_withAutopilotKubeletConfig
TestAccContainerCluster_withAutopilot_withNodePoolAutoConfig
TestAccContainerCluster_withCpuCfsQuotaPool
TestAccContainerCluster_withInsecureKubeletReadonlyPortEnabledInNodePool
TestAccContainerCluster_withKubeletConfig
TestAccContainerCluster_withKubeletConfigShutdownGracePeriod
TestAccContainerCluster_withKubeletResourceManagerConfig
TestAccContainerCluster_withNodeConfigKubeletConfigSettingsInNodePool
TestAccContainerCluster_withNodeConfigKubeletConfigSettingsUpdates
TestAccContainerNodePool_withHostMaintenancePolicy
TestAccContainerNodePool_withKubeletConfig

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccContainerCluster_withAutopilotKubeletConfig
✅ Log	✅	TestAccContainerCluster_withAutopilot_withNodePoolAutoConfig
✅ Log	✅	TestAccContainerCluster_withKubeletConfigShutdownGracePeriod
❌ Error · Log	-	TestAccContainerCluster_regionalWithNodePool
❌ Error · Log	-	TestAccContainerCluster_withCpuCfsQuotaPool
❌ Error · Log	-	TestAccContainerCluster_withInsecureKubeletReadonlyPortEnabledInNodePool
❌ Error · Log	-	TestAccContainerCluster_withKubeletConfig
❌ Error · Log	-	TestAccContainerCluster_withKubeletResourceManagerConfig
❌ Error · Log	-	TestAccContainerCluster_withNodeConfigKubeletConfigSettingsInNodePool
❌ Error · Log	-	TestAccContainerCluster_withNodeConfigKubeletConfigSettingsUpdates
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log	-	TestAccContainerNodePool_withKubeletConfig

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@chenggu88, @trodge VCR tests complete for 0381b68!

modular-magician · 2026-06-18T04:13:21Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 9efcf42:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	2 files changed, 113 insertions(+), 22 deletions(-)
`google-beta` provider	View Diff	2 files changed, 113 insertions(+), 22 deletions(-)
`terraform-google-conversion`	View Diff	2 files changed, 60 insertions(+), 21 deletions(-)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (577 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_pool {
    node_config {
      kubelet_config {
        shutdown_grace_period_critical_pods_seconds = # value needed
        shutdown_grace_period_seconds               = # value needed
      }
    }
  }
  node_pool_auto_config {
    node_kubelet_config {
      shutdown_grace_period_critical_pods_seconds = # value needed
      shutdown_grace_period_seconds               = # value needed
    }
  }
}

Resource: google_container_node_pool (132 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_node_pool" "primary" {
  node_config {
    kubelet_config {
      shutdown_grace_period_critical_pods_seconds = # value needed
      shutdown_grace_period_seconds               = # value needed
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

google_container_cluster
- Expected Document Path: /website/docs/r/container_cluster.html.markdown
- Fields: [node_config.kubelet_config.shutdown_grace_period_critical_pods_seconds node_config.kubelet_config.shutdown_grace_period_seconds node_pool.node_config.kubelet_config.shutdown_grace_period_critical_pods_seconds node_pool.node_config.kubelet_config.shutdown_grace_period_seconds node_pool_auto_config.node_kubelet_config.shutdown_grace_period_critical_pods_seconds node_pool_auto_config.node_kubelet_config.shutdown_grace_period_seconds]
google_container_node_pool
- Expected Document Path: /website/docs/r/container_node_pool.html.markdown
- Fields: [node_config.kubelet_config.shutdown_grace_period_critical_pods_seconds node_config.kubelet_config.shutdown_grace_period_seconds]

Test report

Analytics

Total Tests	Passed	Skipped	Affected
305	279	14	12

Affected Service Packages

container

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

TestAccContainerCluster_regionalWithNodePool
TestAccContainerCluster_withAutopilotKubeletConfig
TestAccContainerCluster_withAutopilot_withNodePoolAutoConfig
TestAccContainerCluster_withCpuCfsQuotaPool
TestAccContainerCluster_withInsecureKubeletReadonlyPortEnabledInNodePool
TestAccContainerCluster_withKubeletConfig
TestAccContainerCluster_withKubeletConfigShutdownGracePeriod
TestAccContainerCluster_withKubeletResourceManagerConfig
TestAccContainerCluster_withNodeConfigKubeletConfigSettingsInNodePool
TestAccContainerCluster_withNodeConfigKubeletConfigSettingsUpdates
TestAccContainerNodePool_withHostMaintenancePolicy
TestAccContainerNodePool_withKubeletConfig

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccContainerCluster_withAutopilotKubeletConfig
✅ Log	✅	TestAccContainerCluster_withAutopilot_withNodePoolAutoConfig
✅ Log	✅	TestAccContainerCluster_withKubeletConfigShutdownGracePeriod
❌ Error · Log	-	TestAccContainerCluster_regionalWithNodePool
❌ Error · Log	-	TestAccContainerCluster_withCpuCfsQuotaPool
❌ Error · Log	-	TestAccContainerCluster_withInsecureKubeletReadonlyPortEnabledInNodePool
❌ Error · Log	-	TestAccContainerCluster_withKubeletConfig
❌ Error · Log	-	TestAccContainerCluster_withKubeletResourceManagerConfig
❌ Error · Log	-	TestAccContainerCluster_withNodeConfigKubeletConfigSettingsInNodePool
❌ Error · Log	-	TestAccContainerCluster_withNodeConfigKubeletConfigSettingsUpdates
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log	-	TestAccContainerNodePool_withKubeletConfig

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@chenggu88, @trodge VCR tests complete for 9efcf42!

modular-magician · 2026-06-18T04:28:26Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f7e6de5:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	5 files changed, 134 insertions(+), 24 deletions(-)
`google-beta` provider	View Diff	5 files changed, 134 insertions(+), 24 deletions(-)
`terraform-google-conversion`	View Diff	2 files changed, 60 insertions(+), 21 deletions(-)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (577 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_pool {
    node_config {
      kubelet_config {
        shutdown_grace_period_critical_pods_seconds = # value needed
        shutdown_grace_period_seconds               = # value needed
      }
    }
  }
  node_pool_auto_config {
    node_kubelet_config {
      shutdown_grace_period_critical_pods_seconds = # value needed
      shutdown_grace_period_seconds               = # value needed
    }
  }
}

Resource: google_container_node_pool (132 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_node_pool" "primary" {
  node_config {
    kubelet_config {
      shutdown_grace_period_critical_pods_seconds = # value needed
      shutdown_grace_period_seconds               = # value needed
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

google_container_cluster
- Expected Document Path: /website/docs/r/container_cluster.html.markdown
- Fields: [node_pool.node_config.kubelet_config.shutdown_grace_period_critical_pods_seconds node_pool.node_config.kubelet_config.shutdown_grace_period_seconds]
google_container_node_pool
- Expected Document Path: /website/docs/r/container_node_pool.html.markdown
- Fields: [node_config.kubelet_config.shutdown_grace_period_critical_pods_seconds node_config.kubelet_config.shutdown_grace_period_seconds]

Test report

Analytics

Total Tests	Passed	Skipped	Affected
305	279	14	12

Affected Service Packages

container

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

TestAccContainerCluster_regionalWithNodePool
TestAccContainerCluster_withAutopilotKubeletConfig
TestAccContainerCluster_withAutopilot_withNodePoolAutoConfig
TestAccContainerCluster_withCpuCfsQuotaPool
TestAccContainerCluster_withInsecureKubeletReadonlyPortEnabledInNodePool
TestAccContainerCluster_withKubeletConfig
TestAccContainerCluster_withKubeletConfigShutdownGracePeriod
TestAccContainerCluster_withKubeletResourceManagerConfig
TestAccContainerCluster_withNodeConfigKubeletConfigSettingsInNodePool
TestAccContainerCluster_withNodeConfigKubeletConfigSettingsUpdates
TestAccContainerNodePool_withHostMaintenancePolicy
TestAccContainerNodePool_withKubeletConfig

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccContainerCluster_withAutopilotKubeletConfig
✅ Log	✅	TestAccContainerCluster_withAutopilot_withNodePoolAutoConfig
✅ Log	✅	TestAccContainerCluster_withKubeletConfigShutdownGracePeriod
❌ Error · Log	-	TestAccContainerCluster_regionalWithNodePool
❌ Error · Log	-	TestAccContainerCluster_withCpuCfsQuotaPool
❌ Error · Log	-	TestAccContainerCluster_withInsecureKubeletReadonlyPortEnabledInNodePool
❌ Error · Log	-	TestAccContainerCluster_withKubeletConfig
❌ Error · Log	-	TestAccContainerCluster_withKubeletResourceManagerConfig
❌ Error · Log	-	TestAccContainerCluster_withNodeConfigKubeletConfigSettingsInNodePool
❌ Error · Log	-	TestAccContainerCluster_withNodeConfigKubeletConfigSettingsUpdates
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log	-	TestAccContainerNodePool_withKubeletConfig

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@chenggu88, @trodge VCR tests complete for f7e6de5!

…pods_seconds fields to GKE cluster kubelet_config

…riod # Conflicts: # mmv1/third_party/terraform/website/docs/r/container_cluster.html.markdown # mmv1/third_party/terraform/website/docs/r/container_node_pool.html.markdown

modular-magician · 2026-06-18T05:04:41Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 3c49862:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	7 files changed, 261 insertions(+), 24 deletions(-)
`google-beta` provider	View Diff	7 files changed, 261 insertions(+), 24 deletions(-)
`terraform-google-conversion`	View Diff	3 files changed, 66 insertions(+), 21 deletions(-)

Missing doc report (experimental)

The following resources have fields missing in documents.

google_container_node_pool
- Expected Document Path: /website/docs/r/container_node_pool.html.markdown
- Fields: [node_config.kubelet_config.shutdown_grace_period_critical_pods_seconds node_config.kubelet_config.shutdown_grace_period_seconds]

Test report

Important

Manual Verification Required

VCR cannot automatically execute the following tests added in this PR. Please verify them manually:

🔴 TestAccContainerCluster_withShutdownGracePeriodStaticCheck

Analytics

Total Tests	Passed	Skipped	Affected
307	282	15	10

Affected Service Packages

container

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

TestAccContainerCluster_regionalWithNodePool
TestAccContainerCluster_withCpuCfsQuotaPool
TestAccContainerCluster_withInsecureKubeletReadonlyPortEnabledInNodePool
TestAccContainerCluster_withKubeletConfig
TestAccContainerCluster_withKubeletResourceManagerConfig
TestAccContainerCluster_withNodeConfigKubeletConfigSettingsInNodePool
TestAccContainerCluster_withNodeConfigKubeletConfigSettingsUpdates
TestAccContainerNodePool_withHostMaintenancePolicy
TestAccContainerNodePool_withKubeletConfig
TestAccContainerNodePool_withKubeletConfigShutdownGracePeriod

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccContainerNodePool_withKubeletConfigShutdownGracePeriod
❌ Error · Log	-	TestAccContainerCluster_regionalWithNodePool
❌ Error · Log	-	TestAccContainerCluster_withCpuCfsQuotaPool
❌ Error · Log	-	TestAccContainerCluster_withInsecureKubeletReadonlyPortEnabledInNodePool
❌ Error · Log	-	TestAccContainerCluster_withKubeletConfig
❌ Error · Log	-	TestAccContainerCluster_withKubeletResourceManagerConfig
❌ Error · Log	-	TestAccContainerCluster_withNodeConfigKubeletConfigSettingsInNodePool
❌ Error · Log	-	TestAccContainerCluster_withNodeConfigKubeletConfigSettingsUpdates
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log	-	TestAccContainerNodePool_withKubeletConfig

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@chenggu88, @trodge VCR tests complete for 3c49862!

modular-magician · 2026-06-18T05:19:06Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 9552c9f:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	7 files changed, 233 insertions(+), 22 deletions(-)
`google-beta` provider	View Diff	7 files changed, 233 insertions(+), 22 deletions(-)
`terraform-google-conversion`	View Diff	3 files changed, 52 insertions(+), 21 deletions(-)

Missing doc report (experimental)

The following resources have fields missing in documents.

google_container_node_pool
- Expected Document Path: /website/docs/r/container_node_pool.html.markdown
- Fields: [node_config.kubelet_config.shutdown_grace_period_critical_pods_seconds node_config.kubelet_config.shutdown_grace_period_seconds]

Test report

Important

Manual Verification Required

VCR cannot automatically execute the following tests added in this PR. Please verify them manually:

🔴 TestAccContainerCluster_withShutdownGracePeriodStaticCheck

Analytics

Total Tests	Passed	Skipped	Affected
307	280	15	12

Affected Service Packages

container

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

TestAccContainerCluster_regionalWithNodePool
TestAccContainerCluster_withAutopilotKubeletConfig
TestAccContainerCluster_withAutopilot_withNodePoolAutoConfig
TestAccContainerCluster_withCpuCfsQuotaPool
TestAccContainerCluster_withInsecureKubeletReadonlyPortEnabledInNodePool
TestAccContainerCluster_withKubeletConfig
TestAccContainerCluster_withKubeletResourceManagerConfig
TestAccContainerCluster_withNodeConfigKubeletConfigSettingsInNodePool
TestAccContainerCluster_withNodeConfigKubeletConfigSettingsUpdates
TestAccContainerNodePool_withHostMaintenancePolicy
TestAccContainerNodePool_withKubeletConfig
TestAccContainerNodePool_withKubeletConfigShutdownGracePeriod

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccContainerCluster_withAutopilotKubeletConfig
✅ Log	✅	TestAccContainerCluster_withAutopilot_withNodePoolAutoConfig
✅ Log	✅	TestAccContainerNodePool_withKubeletConfigShutdownGracePeriod
❌ Error · Log	-	TestAccContainerCluster_regionalWithNodePool
❌ Error · Log	-	TestAccContainerCluster_withCpuCfsQuotaPool
❌ Error · Log	-	TestAccContainerCluster_withInsecureKubeletReadonlyPortEnabledInNodePool
❌ Error · Log	-	TestAccContainerCluster_withKubeletConfig
❌ Error · Log	-	TestAccContainerCluster_withKubeletResourceManagerConfig
❌ Error · Log	-	TestAccContainerCluster_withNodeConfigKubeletConfigSettingsInNodePool
❌ Error · Log	-	TestAccContainerCluster_withNodeConfigKubeletConfigSettingsUpdates
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log	-	TestAccContainerNodePool_withKubeletConfig

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@chenggu88, @trodge VCR tests complete for 9552c9f!

…nfig

modular-magician · 2026-06-18T05:47:34Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 3a1183a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	7 files changed, 246 insertions(+), 22 deletions(-)
`google-beta` provider	View Diff	7 files changed, 246 insertions(+), 22 deletions(-)
`terraform-google-conversion`	View Diff	3 files changed, 52 insertions(+), 21 deletions(-)

Missing doc report (experimental)

The following resources have fields missing in documents.

google_container_node_pool
- Expected Document Path: /website/docs/r/container_node_pool.html.markdown
- Fields: [node_config.kubelet_config.shutdown_grace_period_critical_pods_seconds node_config.kubelet_config.shutdown_grace_period_seconds]

Test report

Analytics

Total Tests	Passed	Skipped	Affected
307	281	14	12

Affected Service Packages

container

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

TestAccContainerCluster_regionalWithNodePool
TestAccContainerCluster_withAutopilotKubeletConfig
TestAccContainerCluster_withAutopilot_withNodePoolAutoConfig
TestAccContainerCluster_withCpuCfsQuotaPool
TestAccContainerCluster_withInlineNodePoolShutdownGracePeriod
TestAccContainerCluster_withInsecureKubeletReadonlyPortEnabledInNodePool
TestAccContainerCluster_withKubeletConfig
TestAccContainerCluster_withKubeletResourceManagerConfig
TestAccContainerCluster_withNodeConfigKubeletConfigSettingsInNodePool
TestAccContainerCluster_withNodeConfigKubeletConfigSettingsUpdates
TestAccContainerNodePool_withHostMaintenancePolicy
TestAccContainerNodePool_withKubeletConfig

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccContainerCluster_withAutopilotKubeletConfig
✅ Log	✅	TestAccContainerCluster_withAutopilot_withNodePoolAutoConfig
✅ Log	✅	TestAccContainerCluster_withInlineNodePoolShutdownGracePeriod
❌ Error · Log	-	TestAccContainerCluster_regionalWithNodePool
❌ Error · Log	-	TestAccContainerCluster_withCpuCfsQuotaPool
❌ Error · Log	-	TestAccContainerCluster_withInsecureKubeletReadonlyPortEnabledInNodePool
❌ Error · Log	-	TestAccContainerCluster_withKubeletConfig
❌ Error · Log	-	TestAccContainerCluster_withKubeletResourceManagerConfig
❌ Error · Log	-	TestAccContainerCluster_withNodeConfigKubeletConfigSettingsInNodePool
❌ Error · Log	-	TestAccContainerCluster_withNodeConfigKubeletConfigSettingsUpdates
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log	-	TestAccContainerNodePool_withKubeletConfig

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@chenggu88, @trodge VCR tests complete for 3a1183a!

… HCL configuration

modular-magician · 2026-06-18T22:06:49Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6b183a5:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	7 files changed, 259 insertions(+), 22 deletions(-)
`google-beta` provider	View Diff	7 files changed, 259 insertions(+), 22 deletions(-)
`terraform-google-conversion`	View Diff	3 files changed, 79 insertions(+), 21 deletions(-)

Missing doc report (experimental)

The following resources have fields missing in documents.

google_container_node_pool
- Expected Document Path: /website/docs/r/container_node_pool.html.markdown
- Fields: [node_config.kubelet_config.shutdown_grace_period_critical_pods_seconds node_config.kubelet_config.shutdown_grace_period_seconds]

Test report

Analytics

Total Tests	Passed	Skipped	Affected
307	291	14	2

Affected Service Packages

container

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

TestAccContainerCluster_regionalWithNodePool
TestAccContainerNodePool_withHostMaintenancePolicy

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
❌ Error · Log	-	TestAccContainerCluster_regionalWithNodePool
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@chenggu88, @trodge VCR tests complete for 6b183a5!

chenggu88 · 2026-06-18T23:51:23Z

TestAccContainerCluster_regionalWithNodePool : related to #17968
TestAccContainerNodePool_withHostMaintenancePolicy: GCE stock out

github-actions · 2026-06-22T11:30:21Z

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions Bot requested a review from trodge June 18, 2026 04:01

chenggu88 force-pushed the add-shutdown-grace-period branch from 0381b68 to 9efcf42 Compare June 18, 2026 04:02

modular-magician added the service/container label Jun 18, 2026

chenggu88 force-pushed the add-shutdown-grace-period branch from 9efcf42 to f7e6de5 Compare June 18, 2026 04:17

Add shutdown_grace_period_seconds and shutdown_grace_period_critical_…

a74692c

…pods_seconds fields to GKE cluster kubelet_config

chenggu88 force-pushed the add-shutdown-grace-period branch from f7e6de5 to a74692c Compare June 18, 2026 04:49

Merge remote-tracking branch 'origin/main' into add-shutdown-grace-pe…

3c49862

…riod # Conflicts: # mmv1/third_party/terraform/website/docs/r/container_cluster.html.markdown # mmv1/third_party/terraform/website/docs/r/container_node_pool.html.markdown

Revert shutdown grace period fields from GKE Autopilot nodePoolAutoCo…

3a1183a

…nfig

chenggu88 force-pushed the add-shutdown-grace-period branch from 9552c9f to 3a1183a Compare June 18, 2026 05:36

Only force-send GKE shutdown grace period fields if explicitly set in…

6b183a5

… HCL configuration

trodge approved these changes Jun 24, 2026

View reviewed changes

trodge added this pull request to the merge queue Jun 24, 2026

Merged via the queue into GoogleCloudPlatform:main with commit 1aaec4b Jun 24, 2026
28 of 29 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add shutdown_grace_period_seconds and shutdown_grace_period_critical_pods_seconds fields to GKE cluster kubelet_config#17999

Add shutdown_grace_period_seconds and shutdown_grace_period_critical_pods_seconds fields to GKE cluster kubelet_config#17999
trodge merged 4 commits into
GoogleCloudPlatform:mainfrom
chenggu88:add-shutdown-grace-period

chenggu88 commented Jun 18, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 18, 2026

Uh oh!

modular-magician commented Jun 18, 2026 •

edited

Loading

Uh oh!

modular-magician commented Jun 18, 2026 •

edited

Loading

Uh oh!

modular-magician commented Jun 18, 2026 •

edited

Loading

Uh oh!

modular-magician commented Jun 18, 2026 •

edited

Loading

Uh oh!

modular-magician commented Jun 18, 2026 •

edited

Loading

Uh oh!

modular-magician commented Jun 18, 2026 •

edited

Loading

Uh oh!

modular-magician commented Jun 18, 2026 •

edited

Loading

Uh oh!

chenggu88 commented Jun 18, 2026

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

chenggu88 commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 18, 2026

Uh oh!

modular-magician commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Missing test report

Missing doc report (experimental)

Test report

Analytics

Action taken

Uh oh!

modular-magician commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Missing test report

Missing doc report (experimental)

Test report

Analytics

Action taken

Uh oh!

modular-magician commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Missing test report

Missing doc report (experimental)

Test report

Analytics

Action taken

Uh oh!

modular-magician commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Missing doc report (experimental)

Test report

Analytics

Action taken

Uh oh!

modular-magician commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Missing doc report (experimental)

Test report

Analytics

Action taken

Uh oh!

modular-magician commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Missing doc report (experimental)

Test report

Analytics

Action taken

Uh oh!

modular-magician commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Missing doc report (experimental)

Test report

Analytics

Action taken

Uh oh!

chenggu88 commented Jun 18, 2026

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chenggu88 commented Jun 18, 2026 •

edited

Loading

modular-magician commented Jun 18, 2026 •

edited

Loading

modular-magician commented Jun 18, 2026 •

edited

Loading

modular-magician commented Jun 18, 2026 •

edited

Loading

modular-magician commented Jun 18, 2026 •

edited

Loading

modular-magician commented Jun 18, 2026 •

edited

Loading

modular-magician commented Jun 18, 2026 •

edited

Loading

modular-magician commented Jun 18, 2026 •

edited

Loading