Dataplex-DataProduct: Adding icon support for DataProduct

[shashambhavi]

Added support for icon field in Dataplex DataProduct.

dataplex: added `icon` field to `google_dataplex_data_product` resource

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit eb5b908:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	3 files changed, 45 insertions(+)
google-beta provider	View Diff	3 files changed, 45 insertions(+)
terraform-google-conversion	View Diff	1 file changed, 10 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_data_product (14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_data_product" "primary" {
  icon = # value needed
}

Test report

Analytics

Total Tests	Passed	Skipped	Affected
91	91	0	0

Affected Service Packages

• dataplex

Learn how VCR tests work

---

Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@shashambhavi, @melinath VCR tests complete for eb5b908!

[melinath]

Could you add this to a test as well?

Probably easiest to do would be to add it to the update test so that the update path is exercised as well: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/services/dataplex/resource_dataplex_data_product_test.go

[shashambhavi]

Could you add this to a test as well?

Probably easiest to do would be to add it to the update test so that the update path is exercised as well: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/services/dataplex/resource_dataplex_data_product_test.go

Done! Added the new field in the tests.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6ea5491:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	4 files changed, 53 insertions(+)
google-beta provider	View Diff	4 files changed, 53 insertions(+)
terraform-google-conversion	View Diff	1 file changed, 10 insertions(+)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
93	92	0	1

Affected Service Packages

• dataplex

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccDataplexDataProduct_update

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccDataplexDataProduct_update

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@shashambhavi, @melinath VCR tests complete for 6ea5491!

[melinath]

LGTM, thanks!