Skip to content

support of updating node_image_config and image_type` at the same time#18015

Open
cwangVT wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
cwangVT:main
Open

support of updating node_image_config and image_type` at the same time#18015
cwangVT wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
cwangVT:main

Conversation

@cwangVT

@cwangVT cwangVT commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

container: added the support of updating `node_image_config  and `image_type` at the same time 

@github-actions github-actions Bot requested a review from NickElliot June 19, 2026 05:18
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f423219:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 3 files changed, 48 insertions(+), 5 deletions(-)
google-beta provider View Diff 3 files changed, 48 insertions(+), 5 deletions(-)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (577 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_pool {
    node_config {
      node_image_config {
        image         = # value needed
        image_project = # value needed
      }
    }
  }
}

Test report

Analytics

Total Tests Passed Skipped Affected
304 287 14 3
Affected Service Packages
  • container

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccContainerCluster_regionalWithNodePool
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccContainerNodePool_withNodeImageConfig

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccContainerNodePool_withNodeImageConfig
❌ Error · Log - TestAccContainerCluster_regionalWithNodePool
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@cwangVT, @NickElliot VCR tests complete for f423219!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants