Add instance group manager bulk per instance config resource.#18017
Add instance group manager bulk per instance config resource.#18017pjotrekk wants to merge 1 commit into
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
| return map[string]*schema.Schema{ | ||
| "name": { | ||
| Type: schema.TypeString, | ||
| OptionalForImport: true, |
There was a problem hiding this comment.
I think we should disable importing
There was a problem hiding this comment.
Removed OptionalForImport
There was a problem hiding this comment.
Sorry, couldn't remove it after all because I'd have to delete the whole identity object where igm is set. Maybe it's ok to remove it but I'm not able to finish it before vacation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit aca9f7f: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_bulk_per_instance_config" "primary" {
zone = # value needed
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportImportant Manual Verification Required VCR cannot automatically execute the following tests added in this PR. Please verify them manually: 🔴 TestAccComputeBulkPerInstanceConfig_allInstancesChanged Analytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1389 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. More than 100 tests failed in replaying; this is too many to display on GitHub. View the Cloud Build logs to see the full list. View the replaying VCR build log Step 2: Recording Mode More than 100 tests ran in recording mode; this is too many to display on GitHub. View the Cloud Build logs to see the result summary. Caution Issues requiring attention before PR completion 🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details. 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 9f0564d: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_bulk_per_instance_config" "primary" {
zone = # value needed
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportImportant Manual Verification Required VCR cannot automatically execute the following tests added in this PR. Please verify them manually: 🔴 TestAccComputeBulkPerInstanceConfig_allInstancesChanged Analytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. Caution Issues requiring attention before PR completion 🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the replaying VCR build log |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 079e842: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_bulk_per_instance_config" "primary" {
zone = # value needed
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportImportant Manual Verification Required VCR cannot automatically execute the following tests added in this PR. Please verify them manually: 🔴 TestAccComputeBulkPerInstanceConfig_allInstancesChanged Analytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. |
This PR introduces a new virtual resource for instance group managers: BulkPerInstanceConfig.
In this version it accepts only instance names which makes it possible to call instanceGroupManagers.CreateInstances with more than 1 instance in a single call. So far it was limited to a single PerInstanceConfig.
BulkPerInstanceConfig is immutable and on each modification it will call instanceGroupManagers.DeleteInstances on Destroy and instanceGroupManagers.CreateInstances on Create. Thanks to that Update is not implemented.
instance group manager should be configured to ignore target_size changes, as BulkPerInstanceConfig modifies this value.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.